Fix issue #5998 - certificates created without server authentication … #6127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cormacpayne Please review this one line hotfix. |
|
Please take this change as an on-demand release hotfix. |
cormacpayne
suggested changes
May 7, 2018
There was a problem hiding this comment.
@juhacket Hey Justin, two comments:
- Please update the Service Fabric change log
- Please make sure there is test coverage to prevent future regressions in this space
|
@cormacpayne Updated change log. New tests will be recorded during the next revision of the cmdlets. |
|
Issue for tracking test debt: #6164 |
cormacpayne
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Certificates created by SF cmdlets are missing "Server Authentication" usage token. These certificates cannot be used to connect to SF cluster resources.
Checklist
CONTRIBUTING.mdplatyPSmodule