Skip to content

Add new rules to SignatureVerifier #6192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 21, 2018

Conversation

cormacpayne
Copy link
Member

@cormacpayne cormacpayne commented May 10, 2018

Description

The following checks have been added to the SignatureVerifier:

  • No output type for a cmdlet
  • Optional positional parameters
  • Parameter set names containing a space
  • Cmdlets with no default parameter set name and multiple sets

Checklist

- No output type
- Optional positional parameters
- Parameter set names containing a space
- Cmdlets with no default parameter set name and multiple sets
maddieclayton
maddieclayton previously approved these changes May 11, 2018
…ic-analysis-rules

# Conflicts:
#	tools/StaticAnalysis/Exceptions/SignatureIssues.csv
maddieclayton
maddieclayton previously approved these changes May 11, 2018
maddieclayton
maddieclayton previously approved these changes May 21, 2018
@maddieclayton
Copy link
Contributor

@cormacpayne this looks good to me once merge conflicts are fixed.

…ic-analysis-rules

# Conflicts:
#	tools/StaticAnalysis/Exceptions/SignatureIssues.csv
@maddieclayton maddieclayton merged commit feb4738 into Azure:preview May 21, 2018
@cormacpayne cormacpayne deleted the static-analysis-rules branch September 12, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants