Skip to content

Updating examples for BGP service communities #6220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2018
Merged

Updating examples for BGP service communities #6220

merged 3 commits into from
May 15, 2018

Conversation

ganesr
Copy link
Contributor

@ganesr ganesr commented May 15, 2018

Description

Updates example for Get-AzureRmBGPServiceCommunity.

Checklist

@ganesr
Copy link
Contributor Author

ganesr commented May 15, 2018

@markjbrown Please let me know if this looks good. If it does, I will do the same for the others.

@@ -1,4 +1,5 @@
---

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ganesr please remove this space added at the top of the file


## EXAMPLES

### Example 1
```
PS C:\> {{ Add example code here }}
Get-AzureRmBgpServiceCommunity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ganesr would you be able to add the corresponding output (or a snippet of it if it's too big) from this cmdlet execution in this code block?

@ganesr
Copy link
Contributor Author

ganesr commented May 15, 2018

@cormacpayne please review updates per your comments.

@cormacpayne
Copy link
Member

@markjbrown these changes look good to me. I can merge the PR whenever you sign off as well.

Copy link
Contributor

@markjbrown markjbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good.

@cormacpayne do these need to get merged into Master for them to be reflected in PS help and docs?

@cormacpayne
Copy link
Member

@markjbrown we release out of the preview branch, so once this PR gets merged, it will get picked up for the next release and will be reflected on https://docs.microsoft.com when the module is published on May 22nd

@cormacpayne cormacpayne merged commit 70679bd into Azure:preview May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants