Update api-version #6249

antoniowmsft · 2018-05-17T22:49:55Z

Description

Update api-version in playback files

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

matthchr · 2018-05-17T22:51:34Z

This looks good to me. @cormacpayne - are the failing tests disabled? Is it possible we can re-enable them for this PR to make sure they are passing after these changes in CI?

cormacpayne · 2018-05-17T22:57:10Z

@antoniowmsft @matthchr the tests are currently disabled in the release-6.1.0 branch, which we plan on merging into the preview branch tomorrow, but you can still verify the fix in this PR using the on-demand job.

Here's the on-demand job for this PR: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/858/

matthchr · 2018-05-18T23:44:59Z

Hmm, it looks like the on-demand job still failed:

  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Jobs.cs(203): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.TaskTests.TestTerminateTask [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Jobs.cs(203): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.TaskTests.TestListAllSubtasks [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Jobs.cs(203): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.TaskTests.TestTaskCRUD [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Jobs.cs(203): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.TaskTests.TestCreateTaskCollection [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Pools.cs(217): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.PoolTests.TestResizeAndStopResizePool [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\AzurePowershell.Test.targets(89,3): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.PoolTests.TestPoolCRUD [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Pools.cs(217): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.PoolTests.TestAutoScaleActions [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Pools.cs(217): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.PoolTests.TestChangeOSVersion [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\PSPagedEnumerable.cs(124): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.FileTests.TestGetRemoteDesktopProtocolFile [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Jobs.cs(203): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.FileTests.TestDeleteNodeFileByTask [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\PSPagedEnumerable.cs(124): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.FileTests.TestGetNodeFileContentByComputeNode [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Jobs.cs(203): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.FileTests.TestDeleteNodeFileByComputeNode [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Jobs.cs(203): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.FileTests.TestGetNodeFileContentByTask [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\AzurePowershell.Test.targets(89,3): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.BatchApplicationPackageTests.TestCreatePoolWithApplicationPackage [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Pools.cs(217): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.BatchApplicationPackageTests.TestUpdatePoolWithApplicationPackage [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\AzurePowershell.Test.targets(89,3): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.JobTests.TestJobCRUD [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Jobs.cs(203): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.JobTests.TestDisableEnableTerminateJob [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\PSPagedEnumerable.cs(124): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.JobTests.IfJobSetsAutoFailure_ItCompletesWhenAnyTaskFails [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\AzurePowershell.Test.targets(89,3): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.CertificateTests.TestCertificateCrudOperations [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Pools.cs(217): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.CertificateTests.TestCancelCertificateDelete [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.JobSchedules.cs(145): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.JobScheduleTests.TestDisableEnableTerminateJobSchedule [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\AzurePowershell.Test.targets(89,3): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.JobScheduleTests.TestJobScheduleCRUD [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\PSPagedEnumerable.cs(124): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ComputeNodeUserTests.TestComputeNodeUserEndToEnd [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\PSPagedEnumerable.cs(124): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ComputeNodeTests.TestDisableAndEnableComputeNodeScheduling [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Pools.cs(217): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ComputeNodeTests.TestRemoveComputeNodes [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\PSPagedEnumerable.cs(124): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ComputeNodeTests.TestGetComputeNodeRemoteLoginSettings [FAIL] [D:\PowerShell-demand\build.proj]
  D:\PowerShell-demand\src\ResourceManager\AzureBatch\Commands.Batch\Models\PSPagedEnumerable.cs(124): error : Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ComputeNodeTests.TestRebootAndReimageComputeNode [FAIL] [D:\PowerShell-demand\build.proj]

The error was:

        System.Collections.Generic.KeyNotFoundException : Unable to find a matching HTTP request for URL 'DELETE /jobs/listSubtaskJob?api-version=2018-03-01.6.1'. Calling method Item().
        Stack Trace:
             at Microsoft.Azure.Test.HttpRecorder.Records.get_Item(String key)
             at Microsoft.Azure.Test.HttpRecorder.HttpMockServer.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
             at System.Net.Http.HttpMessageInvoker.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
             at System.Net.Http.HttpClient.SendAsync(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationToken cancellationToken)
             at System.Net.Http.HttpClient.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
             at Microsoft.Azure.Batch.Protocol.JobOperations.<DeleteWithHttpMessagesAsync>d__6.MoveNext()
          --- End of stack trace from previous location where exception was thrown ---
             at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
             at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
             at Microsoft.Azure.Batch.Protocol.BatchRequestBase`2.<ExecuteRequestWithCancellationAsync>d__42.MoveNext()
          --- End of stack trace from previous location where exception was thrown ---
             at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
             at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
             at Microsoft.Azure.Batch.Protocol.BatchRequestBase`2.<ExecuteRequestAsync>d__40.MoveNext()
          --- End of stack trace from previous location where exception was thrown ---
             at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
             at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
             at Microsoft.Azure.Batch.ProtocolLayer.<ProcessAndExecuteBatchRequest>d__87`1.MoveNext()
          --- End of stack trace from previous location where exception was thrown ---
             at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
             at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
             at Microsoft.Azure.Batch.JobOperations.<DeleteJobAsync>d__22.MoveNext()
          --- End of stack trace from previous location where exception was thrown ---
             at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
             at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
             at Microsoft.Azure.Batch.UtilitiesInternal.WaitAndUnaggregateException(Task task, IEnumerable`1 rootBehaviors, IEnumerable`1 additionalBehaviors)
             at Microsoft.Azure.Batch.JobOperations.DeleteJob(String jobId, IEnumerable`1 additionalBehaviors)
          src\ResourceManager\AzureBatch\Commands.Batch\Models\BatchClient.Jobs.cs(203,0): at Microsoft.Azure.Commands.Batch.Models.BatchClient.DeleteJob(BatchAccountContext context, String jobId, IEnumerable`1 additionBehaviors)
          src\ResourceManager\AzureBatch\Commands.Batch.Test\ScenarioTests\ScenarioTestHelpers.cs(470,0): at Microsoft.Azure.Commands.Batch.Test.ScenarioTests.ScenarioTestHelpers.DeleteJob(BatchController controller, BatchAccountContext context, String jobId)
          src\ResourceManager\AzureBatch\Commands.Batch.Test\ScenarioTests\TaskTests.cs(120,0): at Microsoft.Azure.Commands.Batch.Test.ScenarioTests.TaskTests.<>c__DisplayClass4_0.<TestListAllSubtasks>b__2()
          src\ResourceManager\AzureBatch\Commands.Batch.Test\ScenarioTests\BatchController.cs(138,0): at Microsoft.Azure.Commands.Batch.Test.ScenarioTests.BatchController.RunPsTestWorkflow(Func`1 scriptBuilder, Action initialize, Action cleanup, String callingClassType, String mockName)
          src\ResourceManager\AzureBatch\Commands.Batch.Test\ScenarioTests\TaskTests.cs(108,0): at Microsoft.Azure.Commands.Batch.Test.ScenarioTests.TaskTests.TestListAllSubtasks()

I do see this field in the recording files, it may be that we have to actually fully re-record the tests due to it: EncodedRequestUri

maddieclayton · 2018-05-21T16:18:20Z

@antoniowmsft assigning back to you to address test failures.

maddieclayton · 2018-05-25T23:54:56Z

on demand job here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/884/

maddieclayton · 2018-05-29T17:40:52Z

@antoniowmsft Still seeing some failing test - will keep this PR assigned to you.

maddieclayton · 2018-06-01T23:32:43Z

@antoniowmsft Ping on the failing tests above - are you having issues rerecording these tests?

matthchr · 2018-06-06T16:34:44Z

We can close this PR, I've rebased this PRs contents onto preview and updated to fix the remaining tests (I think), in this PR here: #6405

Update api-version

93e252d

antoniowmsft requested a review from matthchr May 17, 2018 22:49

azuresdkci added the needs-review label May 17, 2018

matthchr previously approved these changes May 18, 2018

View reviewed changes

maddieclayton added needs-revision and removed needs-review labels May 21, 2018

maddieclayton assigned antoniowmsft May 21, 2018

Re-recording scenario tests session records

13e5b8d

antoniowmsft dismissed matthchr’s stale review via 13e5b8d May 25, 2018 20:52

maddieclayton self-assigned this May 25, 2018

maddieclayton removed their assignment May 29, 2018

maddieclayton self-assigned this Jun 4, 2018

Merge branch 'preview' into preview

acaedc6

matthchr mentioned this pull request Jun 6, 2018

Re-record Batch tests #6405

Merged

8 tasks

maddieclayton closed this Jun 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update api-version #6249

Update api-version #6249

Uh oh!

antoniowmsft commented May 17, 2018

Uh oh!

matthchr commented May 17, 2018

Uh oh!

cormacpayne commented May 17, 2018 •

edited

Loading

Uh oh!

matthchr commented May 18, 2018

Uh oh!

maddieclayton commented May 21, 2018

Uh oh!

maddieclayton commented May 25, 2018

Uh oh!

maddieclayton commented May 29, 2018

Uh oh!

maddieclayton commented Jun 1, 2018

Uh oh!

matthchr commented Jun 6, 2018

Uh oh!

Uh oh!

Update api-version #6249

Update api-version #6249

Uh oh!

Conversation

antoniowmsft commented May 17, 2018

Description

Checklist

Uh oh!

matthchr commented May 17, 2018

Uh oh!

cormacpayne commented May 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthchr commented May 18, 2018

Uh oh!

maddieclayton commented May 21, 2018

Uh oh!

maddieclayton commented May 25, 2018

Uh oh!

maddieclayton commented May 29, 2018

Uh oh!

maddieclayton commented Jun 1, 2018

Uh oh!

matthchr commented Jun 6, 2018

Uh oh!

Uh oh!

cormacpayne commented May 17, 2018 •

edited

Loading