Skip to content

CSP Artemis #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 21, 2015
Merged

CSP Artemis #627

merged 8 commits into from
Jul 21, 2015

Conversation

dragonfly91
Copy link

This PR includes the two cmdlets:

  1. Get-AzureBackupContainer
  2. Unregister-AzureBackupContainer

Currently we've committed the BackupServicesManagement.DLL (OneSDK DLL). But, once the corresponding PRs are merged, we'll publish the nuget package and take the dependency on the pkg instead of the DLL.

@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

Hi @dragonfly91, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\..\packages\Microsoft.Azure.Management.BackupServices.1.0.0-preview\lib\net40\Microsoft.Azure.Management.BackupServicesManagement.dll</HintPath>
<HintPath>Resources\Microsoft.Azure.Management.BackupServicesManagement.dll</HintPath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct or recommended. Please increase the version number at you pr in azure-sdk-for-net, publish that, and use the new one

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also sent another PR for azure-sdk-for-net. Once that PR is merged, I will publish the nuget and take dependency on the nuget instead of this DLL. In the meanwhile, can you please continue with the review?

@yugangw-msft
Copy link
Contributor

add to whitelist

yugangw-msft added a commit that referenced this pull request Jul 21, 2015
@yugangw-msft yugangw-msft merged commit 29f3208 into Azure:dev Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants