Release new KeyVault preview module #6284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling Get-AzureRmTrafficManagerProfile with the -Name parameter will return nothing because the cmdlet requires the -ResourceGroupName parameter when using -Name. I've updated the cmdlet parameters to use ParameterSets, which is similar to how other cmdlets handle this situation. The user can either call the cmdlet without any parameters, or with the -ResourceGroupName parameter, or if calling using the -Name parameter, they will now be prompted to enter in a value for the -ResourceGroupName parameter.
I happened to be testing a similar script and think I ran across a few small issues with the examples. 1. $KEKName not set in examples 3&4 2. New-AzureRmADApplication seems to use -CertValue rather than -KeyValue and -KeyType https://docs.microsoft.com/en-us/powershell/module/azurerm.resources/new-azurermadapplication?view=azurermps-5.7.0 3. Looks like the KEK bit is missing from Set-AzureRmVMDiskEncryptionExtension in Example 4 for cert + KEK.
[new-doc] how to generate and use format.ps1xml file (iss #865)
Update Set-AzureRmVMDiskEncryptionExtension.md
There was an blank missing. The link for more details on "Constructing an Account" was not clickable.
Update New-AzureStorageAccountSASToken.md to make hyperlink clickable
schaabs
previously approved these changes
May 23, 2018
cormacpayne
previously approved these changes
May 23, 2018
Fix sign job failure with Commands.Common.Websites
…-location Remove spaces in location before comparision
|
@maddieclayton it looks like you'll need to pull in the latest changes from the |
Fix flaky long running operation test
Introduce Azure Maps cmdlets
added 2 commits
May 23, 2018 15:53
cormacpayne
approved these changes
May 24, 2018
ionuttulai
pushed a commit
to ionuttulai/azure-powershell
that referenced
this pull request
Mar 4, 2020
* update OutputType in cmdlet * add examples for add and remove cmds * fix change log for circuit connection commands * ValidateRange should specify max as 10 * add New-AzureRMNetworkWatcherProtocolConfiguration * start adding test for circuit connection * fix idictionary issue for header * Fix Get-AzureRmTrafficManagerProfile Parameters Calling Get-AzureRmTrafficManagerProfile with the -Name parameter will return nothing because the cmdlet requires the -ResourceGroupName parameter when using -Name. I've updated the cmdlet parameters to use ParameterSets, which is similar to how other cmdlets handle this situation. The user can either call the cmdlet without any parameters, or with the -ResourceGroupName parameter, or if calling using the -Name parameter, they will now be prompted to enter in a value for the -ResourceGroupName parameter. * Update Set-AzureRmVMDiskEncryptionExtension.md I happened to be testing a similar script and think I ran across a few small issues with the examples. 1. $KEKName not set in examples 3&4 2. New-AzureRmADApplication seems to use -CertValue rather than -KeyValue and -KeyType https://docs.microsoft.com/en-us/powershell/module/azurerm.resources/new-azurermadapplication?view=azurermps-5.7.0 3. Looks like the KEK bit is missing from Set-AzureRmVMDiskEncryptionExtension in Example 4 for cert + KEK. * Update Set-AzureRmVMDiskEncryptionExtension.md * Add migration guide for Azure PowerShell 6.0.0 release * record network watcher test * update session record for circuit connection * Update Change Log * Update Markdown Help File * Suppress false-positive breaking change exception for TrafficManager * Support to set based branch for git clone content repo * Update New-AzureStorageAccountSASToken.md There was an blank missing. The link for more details on "Constructing an Account" was not clickable. * Update ChangeLog.md * add circuit connection crud json file to session records * verify playback mode * Add usage detail markdown file * Update paramter sets for gateway operations and help doc * Fix md by removing trailing yaml * Addressed comments on Tag, csproj files, depreciated InvoiceName, missing parameters in PSUsage model * Update ChangeLog Update ChangeLog * [Maps] Rename folders and files from LocationBasedServices * [Maps] Rename help file names * [Maps] Renaming variables, strings, descriptions, etc. * Bumped Network SDK version to 19.0.0-preview * Re-recorded test for VPN Gateway * Remove dll-help.psd1 and .pshproj files * Remove spaces from DeviceProvisioningServices tags field * update help docs for New-AzureRmNetworkWatcherProtocolConfiguration * Re-serialize module metadata and empty BreakingChangeIssues.csv * Fix issue Azure#5998 - certificates created without server authentication usage * Remove missed dll-Help.psd1 reference * Fix issue where default environments weren't being retrieved without a default context set * Recommitting to a new branch to untangle pulls * remove support for set and new commands for circuit connection * Add -ExtendedProperty parameter to New-AzureService and Set-AzureService cmdlets * Fix bug in appveyor.yml * Bumped Network's version in other packages * Updated DNS zone recordings * Suppress credentials in VPN Gateway test * fixed type on example Azure#3 * Fixed incorrect credential suppression * Updated ChangeLog.md * Support piping on all circuit connection commands * Modify Commands.Sql.csproj and Commands.Sql.Test.csproj to use local update Management.Sql.dll binary for now * adding new parameters for create/update elastic pool and database cmdlets. update related db/elastic pool create/update tests * Fix issue in composing PUT request body for database and pool -- Sku object null scenario * Update elasticPool adaptor and communicator to using new sdk when trying to get databases inside a pool (Get-AzureRmSqlElasticPoolDatabase) * Update database replication related models and services to use new autorest sdk (instead of Legacy sdk) to do database copy/secondary, etc. Rerecord all replication related tests * address comments on database/elastic pool cmdlets-- null check, remove commentout codes, etc * address comments. Used -Edition -RequestedServiceObjectiveName for vcore database/pool. Only add new parameter -Vcore to specify vcore number. Modify the database replications, database restore related communicator to use new database webapi * used the published SDK 1.14.0-preview. Update LocationCapabilities model to use new API version (2017 version). Re-record LocationCapability tests * Update all db creation related cmdlets to support vcore database * Update db/elasticpool creation/update tests * Add functions to get skuname when given tier for database and pool, to avoid duplicate codes in cmdlets * use dictionary to mapping tier to skuname * re-record tests and update help file * Update restore cmdlet. Re-recording LTR restore test. Update changeLog. * address comments. and revert all changes related with 'replication links' * using published sdk 1.15.0-preview for the build issue. * Update cmds for creating/updating elasticpool. Use Patch way to do pool update inorder to support correct behaviors for updating pool * fix the yaml trailing issue in help files * Add the removed properties back in DatabaseModel and ElasticPoolModel to avoid breaking changes. And add Edition to BreakingChangeIssue exception * Update BreakingChangeIssues.csv * Address comments. Re-recording part of the failed tests in CI build * re-recording part of the failed tests in CI build. * add new tests records to output dic * Addressed comments on parameter type and typo, and regenerated test sessions * revert changes to common.ps1 * link website for New-AzureRmNetworkWatcherProtocolConfiguration.md * Address PR comments * re-record backup LTR v2 tests, AuditingClassicStorageTests, ThreatDetectionclassicStorageTests * address comments * re-record tests related with ClassicStorage * Fix changelog and minor changes for comments * Fix test TestExportDatabase and re-record it. * Update Remove-AzureRmVirtualNetworkGatewayDefaultSite.md Fixed a typo * Update azure-powershell-design-guidelines.md * Fix null parameter for recurse i setaclentry * fix issue with network watcher md files * Regenerate help files * Update Set-AzureRmVirtualNetwork.md * address vladimir comments * add support to set command to allow piping * removing writing to peer to fix return type * Add StaticAnalysis checks for - No output type - Optional positional parameters - Parameter set names containing a space - Cmdlets with no default parameter set name and multiple sets * Update BreakingChangeIssues.csv * Record auditing & threat detection tests * Update LICENSE.txt updating to recent EULA and 3rd party * Update License.rtf updating eula and 3rd party * revert change to set circuit command * remove value from pipeline by property name from all circuit conneciton commands * Update License.rtf RIpped out unnecessary formatting added by word that caused a view issue inside the msi * Skip severel tests that can only run in live mode (talked with test owner). * Add tests for new static analysis checks * [Maps] Use Maps SDK over LocationBasedServices SDK * fix test * fix test * move from on demand to regular build * Update AzureRM.Network.psd1 * fix based on comments * Update New-AzureRmNetworkWatcherProtocolConfiguration.md * make protocol required * fix test * move from on demand to regular build * Add unittests for new apis * address comments. Remove Sku and PerDatabaseSettings from DatabaseModel and ElasticPoolModel.Modify the database and elastic pool response for powershell. * Update the elastic pool tests. fix bug. * Save export file to adl * Address comments. ReplicationLinkModel, DatabaseCopyModel, remove duplication null check and incorrect help message. * Add dependence in the ServiceManagement sln to fix the sign job * Update SignatureIssues.csv * Add default parameter set for two cmdlets. Update ChangeLog.md and remove unnecessary package files * small type fix * Example fixes for `New-AzureRmStorageAccount`. * Updating examples for BGP service communities.. * Update Get-AzureRmBgpServiceCommunity.md * Update Get-AzureRmBgpServiceCommunity.md * Fix the example for Export-AzureRmDataLakeStoreChildItemProperties * Update Test-AzureRmDnsAvailability Help File Fixed header, added description, added example. * Update changelog file * Fixed header in Get-AzureRmVirtualNetworkPeering * Update Remove-AzureRmVirtualNetworkPeering.md Fixed the header in the file, Added a description and Synopsis * Update AzureRM.Network.md Added descriptions to multiple cmdlets here. * fix breaking change issue and signature issue * Small fix. Use SkuName in the pool model to keep alignment with other models. Rerecord related pool tests * Updating Networking tests with owner attributes * Update ChangeLog.md * Update NewAzureNetworkWatcherProtocolConfiguration.cs * Fix to `New-AzureRmAks` help text. * Fix issue with Clear-AzureRmContext where old default context name was being used for empty context * Strategies library: Version 4, new WriteWarning method. * Websites.Strategies are replaced by Common.Strategies library. * Added comments with full team names * update cmdlets based on autorest .net client 2018-01-01 * Refactor InputObject variables and other review comments * get identity properties from InputObject and allow override by parameters * Skip failing Batch tests in on-demand build (see issue Azure#5006) * Update SignatureIssues.csv * Cleanup dependencies and assembly references * remove one more reference * Update modules for 6.1.0 release * Fix error in paths for Profile RequiredAssemblies * Fix for empty examples. * [Maps] Add legacy ResourceManager & update test recordings * [Maps] Add legacy ResourceManager & update test recordings * Add example to Stop-AzureRmResourceGroupDeployment.md * [Maps] Resolving merge revision requests * [Maps] Resolving merge revision requests (2) * Remove spaces in location before comparision * Update Stack.sln * [Maps] Add PassThru to Remove method, resolve build failure * [Maps] Update help files to reflect -PassThru param addition * [Maps] Fix trailing yaml string for PassThru * Release new KeyVault preview module * address comments * Update KeyVault.sln * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdplatyPSmodule