Skip to content

Fix tests JSON recorded files #6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2018
Merged

Conversation

selasagi
Copy link
Contributor

Description

Fix the json recorded files to enable run tests on playback mode

Checklist

@maddieclayton
Copy link
Contributor

@selasagi What was wrong with these recordings previously? I see that the cs files are marked with "checkin", which means that they are currently running with every CI build and are currently passing.

@selasagi
Copy link
Contributor Author

Are you sure they are running successfully?
They are fails on my dev machine

@maddieclayton maddieclayton self-assigned this May 29, 2018
@maddieclayton
Copy link
Contributor

@selasagi I am fairly certain they were passing previously, though I can't find the last build where PowerBI tests were run. We can definitely accept this PR though, as newer recording are always better.

@maddieclayton
Copy link
Contributor

@maddieclayton maddieclayton merged commit aff4540 into Azure:preview May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants