Skip to content

Update Set-AzureRmSqlServerAuditing and Set-AzureRmSqlDatabaseAuditing Cmdlets #6457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 19, 2018
Merged

Update Set-AzureRmSqlServerAuditing and Set-AzureRmSqlDatabaseAuditing Cmdlets #6457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6c4f5ff
Merge pull request #1 from Azure/preview
bashahee Jun 3, 2018
d957625
Merge pull request #2 from Azure/preview
bashahee Jun 10, 2018
5bf8ca9
Code without tests.
bashahee Jun 10, 2018
e690125
Merge branch 'preview' of https://github.com/bashahee/azure-powershel…
bashahee Jun 10, 2018
59fd805
Adding tests and test records
bashahee Jun 12, 2018
8788cc2
Update test records
bashahee Jun 12, 2018
d4fd33a
Update help files.
bashahee Jun 13, 2018
e2835f9
Update .gitignore
bashahee Jun 13, 2018
6b28948
Merge pull request #3 from Azure/preview
bashahee Jun 17, 2018
4dbd5c4
Combined StorageAccountSubscriptionId and StorageAccountName under sa…
bashahee Jun 17, 2018
2b1e3d1
Update old auditing cmdlets
bashahee Jun 18, 2018
511e2c1
Fix errors regarding md files
bashahee Jun 18, 2018
603268f
Fix error in md file
bashahee Jun 18, 2018
2e20664
Fix examples in md file
bashahee Jun 18, 2018
3de2d5f
Extract some hardcoded strings to constants
bashahee Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...rceManager/Common/Commands.ScenarioTests.ResourceManager.Common/EnvironmentSetupHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,8 @@ public void SetupAzureEnvironmentFromEnvironmentVariables(AzureModule mode)
environment.GraphUrl = currentEnvironment.Endpoints.GraphUri.AbsoluteUri;
environment.AzureDataLakeAnalyticsCatalogAndJobEndpointSuffix = currentEnvironment.Endpoints.DataLakeAnalyticsJobAndCatalogServiceUri.OriginalString.Replace("https://", ""); // because it is just a sufix
environment.AzureDataLakeStoreFileSystemEndpointSuffix = currentEnvironment.Endpoints.DataLakeStoreServiceUri.OriginalString.Replace("https://", ""); // because it is just a sufix
environment.StorageEndpointSuffix = AzureEnvironmentConstants.AzureStorageEndpointSuffix;

#if !NETSTANDARD
if (!ProfileClient.Profile.EnvironmentTable.ContainsKey(testEnvironmentName))
{
Expand Down
3 changes: 3 additions & 0 deletions src/ResourceManager/Sql/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
-->
## Current Release
* Updated example in the help file for Get-AzureRmSqlDatabaseExpanded
* Updated Set-AzureRmSqlServerAuditing and Set-AzureRmSqlDatabaseAuditing Cmdlets
- Added a new parameter called StorageAccountSubscriptionId.
- Added a new example for each modified cmdlet.

## Version 4.6.0
* Updated the following cmdlets with optional LicenseType parameter
Expand Down
27 changes: 27 additions & 0 deletions src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/BlobAuditingTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,20 @@ function Test-BlobAuditingOnDatabase
Assert-AreEqual $policy.RetentionInDays 8
Assert-True { $policy.StorageKeyType -eq "Primary"}

# Test - Tests setting blob auditing policy on a database with a storage account in a subscription which is different than the database's subscription
Set-AzureRmSqlDatabaseAuditing -State Enabled -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -StorageAccountName datasecpstests -AuditActionGroup "SUCCESSFUL_DATABASE_AUTHENTICATION_GROUP", "FAILED_DATABASE_AUTHENTICATION_GROUP" -RetentionInDays 8 -StorageAccountSubscriptionId b403f7d6-87fb-4a39-8b34-b2172f985b78
$policy = Get-AzureRmSqlDatabaseAuditing -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName

# Assert
Assert-AreEqual $policy.AuditState "Enabled"
Assert-AreEqual $policy.AuditActionGroup.Length 2
Assert-True {$policy.AuditActionGroup.Contains([Microsoft.Azure.Commands.Sql.Auditing.Model.AuditActionGroups]::SUCCESSFUL_DATABASE_AUTHENTICATION_GROUP)}
Assert-True {$policy.AuditActionGroup.Contains([Microsoft.Azure.Commands.Sql.Auditing.Model.AuditActionGroups]::FAILED_DATABASE_AUTHENTICATION_GROUP)}
Assert-AreEqual $policy.AuditAction.Length 0
Assert-AreEqual $policy.RetentionInDays 8
Assert-True { $policy.StorageKeyType -eq "Primary"}
Assert-AreEqual $policy.StorageAccountSubscriptionId "b403f7d6-87fb-4a39-8b34-b2172f985b78"

# Test
Set-AzureRmSqlDatabaseAuditing -State Enabled -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -StorageAccountName $params.storageAccount -StorageKeyType "Secondary" -AuditActionGroup "SUCCESSFUL_DATABASE_AUTHENTICATION_GROUP", "FAILED_DATABASE_AUTHENTICATION_GROUP" -RetentionInDays 8 -AuditAction "UPDATE ON database::[$($params.databaseName)] BY [public]"
$policy = Get-AzureRmSqlDatabaseAuditing -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName
Expand Down Expand Up @@ -579,6 +593,19 @@ function Test-BlobAuditingOnServer
Assert-AreEqual $policy.RetentionInDays 8
Assert-AreEqual $policy.StorageKeyType "Primary"

# Test - Tests setting blob auditing policy on a server with a storage account in a subscription which is different than the server's subscription
Set-AzureRmSqlServerAuditing -State Enabled -ResourceGroupName $params.rgname -ServerName $params.serverName -StorageAccountName datasecpstests -AuditActionGroup "SUCCESSFUL_DATABASE_AUTHENTICATION_GROUP", "FAILED_DATABASE_AUTHENTICATION_GROUP" -RetentionInDays 8 -StorageAccountSubscriptionId b403f7d6-87fb-4a39-8b34-b2172f985b78
$policy = Get-AzureRmSqlServerAuditing -ResourceGroupName $params.rgname -ServerName $params.serverName

# Assert
Assert-AreEqual $policy.AuditState "Enabled"
Assert-AreEqual $policy.AuditActionGroup.Length 2
Assert-True {$policy.AuditActionGroup.Contains([Microsoft.Azure.Commands.Sql.Auditing.Model.AuditActionGroups]::SUCCESSFUL_DATABASE_AUTHENTICATION_GROUP)}
Assert-True {$policy.AuditActionGroup.Contains([Microsoft.Azure.Commands.Sql.Auditing.Model.AuditActionGroups]::FAILED_DATABASE_AUTHENTICATION_GROUP)}
Assert-AreEqual $policy.RetentionInDays 8
Assert-AreEqual $policy.StorageKeyType "Primary"
Assert-AreEqual $policy.StorageAccountSubscriptionId "b403f7d6-87fb-4a39-8b34-b2172f985b78"

# Test
Set-AzureRmSqlServerAuditing -State Enabled -ResourceGroupName $params.rgname -ServerName $params.serverName -StorageAccountName $params.storageAccount -StorageKeyType "Secondary" -AuditActionGroup "SUCCESSFUL_DATABASE_AUTHENTICATION_GROUP", "FAILED_DATABASE_AUTHENTICATION_GROUP" -RetentionInDays 8
$policy = Get-AzureRmSqlServerAuditing -ResourceGroupName $params.rgname -ServerName $params.serverName
Expand Down
Loading