DSC extension refactored code for ARM & ASM #647
Conversation
…into storage-suffix
Fix Storage Endpoint Suffix
…refactoring Conflicts: src/Common/Commands.Common/Properties/Resources.resx
…into dev Conflicts: src/ResourceManager/Compute/Commands.Compute/Extension/DSC/PublishAzureVMDscConfigurationCommand.cs src/ResourceManager/Compute/Commands.Compute/Extension/DSC/SetAzureVMDscExtensionCommand.cs src/ResourceManager/Compute/Commands.Compute/Microsoft.Azure.Commands.Compute.dll-Help.xml src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/DSC/PublishAzureVMDscConfiguration.cs src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/DSC/SetAzureVMDscExtension.cs src/ServiceManagement/Compute/Commands.ServiceManagement/Microsoft.WindowsAzure.Commands.ServiceManagement.dll-Help.xml
…t ommitted during refactoring
|
Hi @eshaparmar, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
@azuresdkci add to whitelist |
|
Started on demand test run - http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/35/ |
| @@ -103,12 +103,16 @@ | |||
| <SpecificVersion>False</SpecificVersion> | |||
| <HintPath>..\..\packages\Microsoft.WindowsAzure.Management.4.1.1\lib\net40\Microsoft.WindowsAzure.Management.dll</HintPath> | |||
| </Reference> | |||
| <Reference Include="Microsoft.WindowsAzure.Storage"> | |||
There was a problem hiding this comment.
Looks like you've added a new DLL to the output. Please regenerate WIX file if that is the case
There was a problem hiding this comment.
I am not sure why we need to regenerate the wix file. We haven't added any new project/assembly. Just re-using an existing one(Microsoft.WindowsAzure.Management) and added it as a reference to the Command.Common project.
|
Started MSI build - http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-msi/362/ |
DSC extension refactored code for ARM & ASM
These changes mainly consist of refactored code that supports both ARM and ASM. We have moved a lot of common code for ARM/ASM at one place instead of writing it in two places.