Skip to content

Task adl fixencodingparameter #6598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 7, 2018
Merged

Task adl fixencodingparameter #6598

merged 14 commits into from
Dec 7, 2018

Conversation

rahuldutta90
Copy link
Contributor

Description

Change FileSystemCmdletProviderEncoding usage to System.Text.Encoding

#5742

Checklist

@cormacpayne
Copy link
Member

@rahuldutta90 we're going to close this PR until @MiYanni creates the new branch (some time in the next week) and then we will target this PR at that branch rather than the preview branch, which would introduce a breaking change into the desktop cmdlets

@rahuldutta90 rahuldutta90 reopened this Nov 14, 2018
@MiYanni
Copy link
Contributor

MiYanni commented Nov 14, 2018

@rahuldutta90 These changes will be in the dev branch we are actually creating end of this week/start of next week. I just don't want any of these changes to be in the AzureRM codebase. They should strictly be for Az.

@MiYanni MiYanni self-assigned this Nov 14, 2018
@maddieclayton maddieclayton added Breaking Change Release This PR contains breaking change and removed Do Not Merge 🚫 labels Nov 16, 2018
@cormacpayne cormacpayne changed the base branch from preview to dev November 28, 2018 18:49
@cormacpayne
Copy link
Member

@rahuldutta90 @MiYanni changed target branch from preview to dev

@cormacpayne cormacpayne changed the base branch from dev to preview November 28, 2018 21:03
@cormacpayne cormacpayne changed the base branch from preview to master November 30, 2018 22:26
@cormacpayne
Copy link
Member

cormacpayne commented Nov 30, 2018

@rahuldutta90 changed the branch to be our new default branch, master. Would you mind taking a look at the merge conflicts?

Note: since the next release is the GA of the Az module, we have removed all reference docs to AzureRM cmdlets, so you will need to regenerate your help based on the Az cmdlets.

@cormacpayne
Copy link
Member

@rahuldutta90 ping on the above comments

@rahuldutta90
Copy link
Contributor Author

@cormacpayne Apologies for delay. Will take a look at it.

@MiYanni
Copy link
Contributor

MiYanni commented Dec 5, 2018

@rahuldutta90 These changes can be put into your cmdlets now. So, once you have the build working properly, we can add merge this and have the changes in Az. Sorry for the delay.

@rahuldutta90 rahuldutta90 removed the request for review from asikaria-msft December 5, 2018 23:44
@rahuldutta90
Copy link
Contributor Author

@MiYanni @cormacpayne Fixed the conflicts, please take a look. Sorry for this delay.

Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiYanni MiYanni merged commit 97ad57e into master Dec 7, 2018
@maddieclayton maddieclayton deleted the task-adl-fixencodingparameter branch December 14, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Release This PR contains breaking change needs-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants