Skip to content

Powershell commandlet to enable diagnostics for V2 VM #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2015
Merged

Powershell commandlet to enable diagnostics for V2 VM #662

merged 2 commits into from
Jul 31, 2015

Conversation

rahulpandit85
Copy link
Contributor

Contains following changes

  1. Get, Set and Remove Azure Powershell commandlets for IaaS V2 VM.
  2. Moved common code between ServiceManagement and ResourceManager diagnostics commandlets in to DiagnosticsHelper class.

@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

Hi @rahulpandit85, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@hovsepm
Copy link
Contributor

hovsepm commented Jul 28, 2015

@azuresdkci test this please

@hovsepm
Copy link
Contributor

hovsepm commented Jul 28, 2015

@rahulpandit85 , could you sign the CLA?

@rahulpandit85
Copy link
Contributor Author

Hi,
I work for Microsoft Visual Studio Cloud tools team.
I don't think the CLA applies to me.
Let me know if otherwise.

stankovski
stankovski reviewed Jul 29, 2015
View reviewed changes
src/ResourceManager/Compute/Commands.Compute/Commands.Compute.csproj
@@ -121,6 +121,9 @@
<HintPath>..\..\..\packages\Newtonsoft.Json.6.0.4\lib\net45\Newtonsoft.Json.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Microsoft.WindowsAzure.Management.Storage">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this change adds a new DLL to the output please update WIX file

@stankovski
Copy link
Member

Started on-demand job - http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/37/
Started MSI build job - http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-msi/356/

@stankovski
Copy link
Member

@rahulpandit85 merge conflicts

@rahulpandit85
Copy link
Contributor Author

Merged with Azure\azure-powershell\dev

@hovsepm
Copy link
Contributor

hovsepm commented Jul 31, 2015

@azuresdkci add to whitelist

hovsepm pushed a commit that referenced this pull request Jul 31, 2015
Merge pull request #662 from rahulpandit85/dev
648c7ba 
Powershell commandlet to enable diagnostics for V2 VM
@hovsepm hovsepm merged commit 648c7ba into Azure:dev Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rahulpandit85 @azuresdkci @azurecla @hovsepm @stankovski