Recovery services Netstandard + Module merge for .netStandard

[viverm]

Description

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate change log has been updated
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • the changes have gone through a cmdlet design review
  • the cmdlet markdown files were generated using the platyPS module

[maddieclayton]

@viverm Looks like you currently have two test dlls for RecoveryServices.SiteRecovery, one in RecoveryServices and one in RecoveryServices.SiteRecovery. That is why the move is failing - please remove the RecoveryServices.SiteRecovery file once you are confident that all the code has been moved successfully into the RecoveryServices folder, and the tests will no longer fail.

[viverm]

@maddieclayton / @MiYanni
I moved the RecoveryServices.SiteRecovery code to recovery services and test in desktop running fine.
When build the project with build.proj getting the error
https://azuresdkci.westus2.cloudapp.azure.com/job/powershell/6787/console

dll is mentioned in csproj file and defined in psd1 dependency but still it is not able to find it.

_

> C:\workspace\powershell\tools\CheckAssemblies.ps1 : error : Assembly Security.Cryptography was not included in the [c:\workspace\powershell\build.proj]
> 04:58:14   c:\workspace\powershell\build.proj(372,5): error MSB3073: The command ""C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NonInteractive -NoLogo -NoProfile -Command ". c:\workspace\powershell\tools\CheckAssemblies.ps1 -BuildConfig Debug "" exited with code 1.

_

[MiYanni]

@viverm You removed Security.Cryptography.dll from AzureRM.RecoveryServices.Backup.psd1. Was that your intention? That psd1 is used for the desktop build. The Az. version is for NetStandard.

[viverm]

@MiYanni Intentionally removed the dll from backup as it is not used in that module.

@dragonfly91 Can you also check the code once.

[viverm]

@MiYanni please help with build failure issue.

_

C:\workspace\powershell\tools\CheckAssemblies.ps1 : error : Assembly Security.Cryptography was not included in the [c:\workspace\powershell\build.proj]
04:58:14 c:\workspace\powershell\build.proj(372,5): error MSB3073: The command ""C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NonInteractive -NoLogo -NoProfile -Command ". c:\workspace\powershell\tools\CheckAssemblies.ps1 -BuildConfig Debug "" exited with code 1.

_

[MiYanni]

@viverm So, looking through your code, Commands.RecoveryServices still relies on Security.Cryptography. The project, Commands.RecoveryServices.Backup.ServiceClientAdapter, depends on Commands.RecoveryServices. The project, Commands.RecoveryServices.Backup, depends on Commands.RecoveryServices.Backup.ServiceClientAdapter. Therefore, Commands.RecoveryServices.Backup relies on Security.Cryptography. So, you have to remove the dependency on Security.Cryptography for everything.

[viverm]

@MiYanni travis build is struck from long time.
Desktop build passed
Can you please check .

[MiYanni]

@viverm The Travis build won't run until you resolve your conflicts. The Travis build is different from the Jenkins build. The Travis build merges latest preview into your branch to do a build. So, if it detects a conflict, it won't run the build. Jenkins simply uses the bits from your branch to run.

[MiYanni]

This has a lot of great changes in it! There are just a few issues to fix up. Let me know if you have any questions based on my comments.

[MiYanni]

The test projects should not output into the Package directory. They simply use the normal bin directory in the project root.

[viverm]

I am seeing the similar pattern in compute and keyvault
do you change the profile to recoveryServices?

[viverm]

@MiYanni check the Azure.PowerShell.Netcore.sln chagnes, I am not sure about it after merge .

[MiYanni]

@viverm You have the same file twice. One with capital RM and the other with Rm

[viverm]

@MiYanni build successful . Let me know if any other fix or concern

[MiYanni]

ps-sign: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/1153/
psnetsign: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/psnetsign/150/
demand: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/1076/

[archmangler]

I'm still seeing this issue on Ubuntu 16.04 with powershell PowerShell 6.1.0 (after apt-get update && apt-get upgrade powershell) and reinstalling the AzureRM.NetCore module:

PS /home/me> Get-AzureRmRecoveryServicesVault -Name myRecoveryServicesVault | Set-AzureRmRecoveryServicesVaultContext
Get-AzureRmRecoveryServicesVault : The term 'Get-AzureRmRecoveryServicesVault' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ Get-AzureRmRecoveryServicesVault -Name myRecoveryServicesVault | Set- ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : ObjectNotFound: (Get-AzureRmRecoveryServicesVault:String) [], CommandNotFoundException
+ FullyQualifiedErrorId : CommandNotFoundException

Is this fix available in the ubuntu package yet?

[MiYanni]

@archmangler This change is in our Az package, which is replacing both AzureRM and AzureRM.Netcore.
https://www.powershellgallery.com/packages/Az/0.2.2
We are no longer releasing anymore AzureRM.Netcore packages. AzureRM (Windows) will be deprecated by end-of-year.

[archmangler]

@MiYanni - thanks, I see the new installation command. Issue fixed.