Convert StaticAnalysis to .NET Core #6979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating template to include all modules and debugpreference can be copied directly into a ps session
cormacpayne
commented
Aug 22, 2018
| @@ -226,10 +229,6 @@ private void LogBreakingChangesInModule(BreakingChangeAttributesInModule moduleD | |||
| foreach (BreakingChangeAttributesInCmdlet cmdletData in moduleData.CmdletList) | |||
| { | |||
| textForBreakingChangesInModule += string.Format(BREAKING_CHANGE_CMDLET_HEADER_FORMAT_STRING, cmdletData.CmdletName); | |||
| foreach (GenericBreakingChangeAttribute attribute in cmdletData.BreakingChangeAttributes) | |||
cormacpayne
commented
Aug 22, 2018
| @@ -58,14 +56,10 @@ public BreakingChangeAttributesInModule GetModuleBreakingChangeAttributes(string | |||
| foreach (var type in assembly.GetCmdletTypes()) | |||
| { | |||
| var cmdlet = type.GetAttribute<CmdletAttribute>(); | |||
| var attributes = type.GetAttributes<GenericBreakingChangeAttribute>(); | |||
markcowl
previously approved these changes
Aug 22, 2018
…ic-analysis-netcore
…l into static-analysis-netcore
MiYanni
approved these changes
Aug 23, 2018
| @@ -44,7 +44,7 @@ $PSVersionTable | |||
|
|
|||
| ### Debug Output | |||
|
|
|||
| <!-- Please run the above script with $DebugPreference = "Continue" and paste the resulting debug stream in the below code block --> | |||
| <!-- Please run the above script with $DebugPreference='Continue' and paste the resulting debug stream in the below code block --> | |||
| @@ -22,7 +22,6 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.Azure.Management.Storage" Version="7.1.0-preview" /> | |||
There was a problem hiding this comment.
Common projects aren't used... why the change(s)?
| @@ -26,7 +26,6 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.Azure.Management.Storage" Version="7.1.0-preview" /> | |||
There was a problem hiding this comment.
Common projects aren't used... why the change(s)?
| @@ -30,7 +30,7 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="Azure.Batch" Version="8.1.1" /> | |||
| <PackageReference Include="Microsoft.Azure.Management.Batch" Version="4.2.0" /> | |||
| <PackageReference Include="Microsoft.Extensions.Primitives" Version="2.1.1" /> | |||
| <PackageReference Include="Microsoft.Extensions.Primitives" Version="1.1.0" /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #5900
Convert StaticAnalysis project to .NET Core and ensure that the DependencyAnalyzer is run as a part of the .NET Core build.
Checklist
CONTRIBUTING.mdplatyPSmodule