-
Notifications
You must be signed in to change notification settings - Fork 4k
Added Storage Scenario Tests. #7037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Issue #6930 |
@NelsonDaniel Is this ready for one of us to take a look at? |
@maddieclayton yes, it is ready for one of you to take a look at. |
Generally looks good to me, and I have approved it. Only one minor concern: I see we will create a storage account for each cases. This looks a little time consuming. Can we share the storage account for all cases? |
@blueww thank you for the feedback. Certainty, that is something I can look into. However, I’m currently doing some training and I will be blocked until the first week of September. |
@blueww I just added additional logic to the tests (i.e. testBlob and testCommon) so there is a wait time to have the service updates reflected before an assertion is performed. |
...urceManager/Storage/Commands.Management.Storage.Test/ScenarioTests/StorageDataPlaneTests.ps1
Outdated
Show resolved
Hide resolved
approve with a minor comment. |
@markcowl This PR is ready to merge. |
Description
Added storage data plane test to netstandard automation.
Checklist
CONTRIBUTING.md
platyPS
module