Skip to content

AzureRT S52 PR #1 #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Aug 11, 2015
Merged

AzureRT S52 PR #1 #710

merged 31 commits into from
Aug 11, 2015

Conversation

huangpf
Copy link
Contributor

@huangpf huangpf commented Aug 7, 2015

  • Fix & Test Set-AzureDeployment with -ExtensionConfiguration
  • Fix & Test NextLink

@azurecla
Copy link

azurecla commented Aug 7, 2015

Hi @huangpf, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (phuang). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@amarzavery
Copy link
Contributor

@@ -116,5 +116,12 @@ public void TestGetVMSizeFromAllLocations()
{
ComputeTestController.NewInstance.RunPsTest("Test-GetVMSizeFromAllLocations");
}

[Fact(Skip = "Fix NextLink")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we want to skip it? Your PR comment claims you are fixing the "nextlink"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client library has some problems. Will be updating the client & test soon.

@huangpf huangpf changed the title AzureRT S52 PR #1 [do not merge] AzureRT S52 PR #1 Aug 7, 2015
@huangpf huangpf changed the title [do not merge] AzureRT S52 PR #1 AzureRT S52 PR #1 Aug 7, 2015
@huangpf
Copy link
Contributor Author

huangpf commented Aug 7, 2015

@amarzavery Everything is included now. Please help review. Thanks.

@huangpf
Copy link
Contributor Author

huangpf commented Aug 10, 2015

@stankovski
Copy link
Member

@stankovski
Copy link
Member

stankovski added a commit that referenced this pull request Aug 11, 2015
@stankovski stankovski merged commit c0400e5 into Azure:dev Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants