Skip to content

[Compute] Remove unused code path #7105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2018
Merged

[Compute] Remove unused code path #7105

merged 1 commit into from
Sep 4, 2018

Conversation

hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Aug 31, 2018 •
edited
Loading

Description

Checklist

hyonholee
hyonholee commented Aug 31, 2018
View reviewed changes
...eManager/Compute/Commands.Compute/Generated/ContainerService/ContainerServiceDeleteMethod.cs
[Cmdlet("Remove", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ContainerService", DefaultParameterSetName = "DefaultParameter", SupportsShouldProcess = true)]
[OutputType(typeof(void))]
[Cmdlet(VerbsCommon.Remove, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ContainerService", DefaultParameterSetName = "DefaultParameter", SupportsShouldProcess = true)]
[OutputType(typeof(PSOperationStatusResponse))]
Copy link
Contributor Author

@hyonholee hyonholee Aug 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this cmdlet outputs PSOperationStatusResponse object, but this value was incorrectly set to void. Thus, I'm fixing it here.

maddieclayton
maddieclayton approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@maddieclayton maddieclayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Glad you are removing this unused code.

@maddieclayton maddieclayton merged commit f952887 into Azure:preview Sep 4, 2018
@hyonholee hyonholee deleted the remove branch November 14, 2018 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddieclayton maddieclayton maddieclayton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyonholee @maddieclayton @azuresdkci1x