Merge NRP's August branch in preview #7113

anton-evseev · 2018-08-31T18:05:53Z

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

…re-powershell into publicipprefixaugust

Publicipprefixaugust

Sync august branch with preview

# Conflicts: # src/ResourceManager/Compute/Commands.Compute.Test/Commands.Compute.Test.Netcore.csproj # src/ResourceManager/Compute/Commands.Compute.Test/packages.config # src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkWatcherAPITests/TestConnectionMonitor.json # src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkWatcherAPITests/TestConnectivityCheck.json # src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkWatcherAPITests/TestFlowLog.json # src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkWatcherAPITests/TestGetNextHop.json # src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkWatcherAPITests/TestGetSecurityGroupView.json # src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkWatcherAPITests/TestGetTopology.json # src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkWatcherAPITests/TestPacketCapture.json # src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkWatcherAPITests/TestProvidersList.json # src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkWatcherAPITests/TestReachabilityReport.json # src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkWatcherAPITests/TestTroubleshoot.json # src/ResourceManager/Network/Commands.Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.NetworkWatcherAPITests/TestVerifyIPFlow.json # src/ResourceManager/Profile/Commands.Profile/AzureRmAlias/Mappings.cs # tools/AliasMapping.json

praries880 · 2018-08-31T18:34:50Z

src/ResourceManager/KeyVault/Commands.KeyVault.Test/ScenarioTests/KeyVaultManagementTests.cs

@@ -406,7 +406,7 @@ public void TestCreateDeleteVaultWithPiping()

        #endregion

-        [Fact]
+        [Fact(Skip = "Fails in playback")]


the bump in the network SDK version is causing this test to fail in playback? this needs to b looked at...

praries880 · 2018-08-31T18:37:08Z

src/ResourceManager/Network/Commands.Network.Test/Commands.Network.Test.csproj

@@ -43,8 +43,28 @@
    <RunCodeAnalysis>false</RunCodeAnalysis>
  </PropertyGroup>
  <ItemGroup>
+    <Reference Include="Hyak.Common">


You will need to revert these includes here... outside of the version change in network nothing else is required. The libraries are pulled in by other common dependencies.

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/ApplicationGatewayTests.ps1

praries880 · 2018-08-31T18:41:20Z

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/NetworkWatcherAPITests.cs

@@ -69,7 +69,7 @@ public void TestPacketCapture()
            NetworkResourcesController.NewInstance.RunPsTest(_logger, "Test-PacketCapture");
        }

-        [Fact(Skip = "Rerecord tests")]
+        [Fact(Skip = "Skipped for due to playback mode failures.")]


The test failure needs to be investigated... what caused it to now fail in playback mode?

praries880 · 2018-08-31T18:42:44Z

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/VirtualNetworkTests.cs

        public void TestVirtualNetworkSubnetCRUD()
        {
            NetworkResourcesController.NewInstance.RunPsTest(_logger, "Test-subnetCRUD");
        }

-        [Fact]
+        [Fact(Skip = "'The '1' auxiliary tokens are either not application token(s) or are from the application(s) ... which are different from the application of primary identity <...>.' StatusCode: 401; ReasonPhrase: Unauthorized.")]


did something change here to make this test now fail?

praries880 · 2018-08-31T18:50:46Z

...nager/Network/Commands.Network/ServiceEndpointPolicy/NewAzureServiceEndpointPolicyCommand.cs

+        public override void Execute()
+        {
+            base.Execute();
+            WriteWarning("The output object type of this cmdlet will be modified in a future release.");


kindly use the breaking change attributes to call out breaking changes

talked with @chandrasekarsrinivasan, cmdlet's output is not going to be changed. Will remove this line

praries880 · 2018-08-31T18:51:17Z

src/ResourceManager/Network/Commands.Network/PublicIpPrefix/NewAzurePublicIpPrefixCommand.cs

+        public override void Execute()
+        {
+            base.Execute();
+            WriteWarning("The output object type of this cmdlet will be modified in a future release.");


kindly use the breaking change attributes to call out breaking changes

talked with @chandrasekarsrinivasan, cmdlet's output is not going to be changed. Will remove this line

praries880 · 2018-08-31T19:01:38Z

src/ResourceManager/Sql/Commands.Sql.Test/Commands.Sql.Test.csproj

@@ -48,8 +48,12 @@
      <SpecificVersion>False</SpecificVersion>
      <HintPath>..\..\..\packages\Microsoft.Azure.Graph.RBAC.3.2.0-preview\lib\net45\Microsoft.Azure.Graph.RBAC.dll</HintPath>
    </Reference>
+    <Reference Include="Microsoft.Azure.Management.Authorization, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


revert this change

praries880 · 2018-08-31T20:19:29Z

@number213 Changes outside the tests look good. Once the tests are fixed ill approve the PR.

praries880 · 2018-08-31T20:27:38Z

on demand : https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/1073/

praries880 · 2018-08-31T20:28:57Z

sign job : https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/1141/

praries880

Approving with the understanding that the fix of the three skipped tests is owned by NRP in the preview branch

Anil Ingle and others added 30 commits August 1, 2018 19:00

Introduce PublicIpPrefix powershell commandlets

bf78734

Remove IdleTimeout Parameter

c4e06f2

Help files updated

4e991f0

Add examples and description

15e68a3

Fix up per PR feedback

820085d

Merge branch 'network-august-release' of https://github.com/Azure/azu…

e54e1da

…re-powershell into publicipprefixaugust

Use Signed Package and Update Netcore.csproj to new package reference

d7c8b5e

Update for test records

40202fc

remove idletimeout

2d2b187

Fix reference to pkg

5588e10

Add PublicIpPrefix

3be9ec5

Update package reference

68edf73

Add online help link

7524e7a

Address PR feedback - add default parameterset

9b4b6ff

Added current release functionality

bd507c7

Merge pull request Azure#6876 from anilingle-ms/publicipprefixaugust

b35f05e

Publicipprefixaugust

Powershell changes for service endpointpolicies

8eef946

Remove references from csproj

cee2856

Further changes

59d35f3

Add files removed from csproj in merge

e62c540

Powershell changes for service endpointpolicies

6cc0f96

Remove references from csproj

7698379

Further changes

c21d80a

Powershell changes for service endpointpolicies

b9f1ea3

Remove references from csproj

608ea9b

Further changes

df43a45

Revert unwanted changes

fed69ad

Fix netcod depndencies

b96ea7f

Fix netcod depndencies

c483a38

Fix help files

ceefbb9

Maddie Clayton and others added 9 commits August 30, 2018 17:30

Update KeyVaultManagementTests.cs

7c766d4

Update Commands.Network.Test.csproj

4eb8048

Update Commands.Network.Test.csproj

31cdab2

Update KeyVaultManagementTests.cs

5c9115d

Merge pull request Azure#7054 from EvgenyAgafonchikov/sync-aug

f57c16f

Sync august branch with preview

Updated NW's recordings

ab315e9

Updated alias mappings

5496f7f

Remove duplicate package from Compute.Test

81b7753

anton-evseev mentioned this pull request Aug 31, 2018

Merge network-august-release into preview #7112

Closed

8 tasks

anton-evseev requested a review from maddieclayton August 31, 2018 18:16

praries880 self-assigned this Aug 31, 2018

azuresdkci1x added the needs-review label Aug 31, 2018

praries880 suggested changes Aug 31, 2018

View reviewed changes

praries880 assigned anton-evseev and unassigned praries880 Aug 31, 2018

praries880 added needs-revision and removed needs-review labels Aug 31, 2018

Addressed PR feedback

cd82507

anton-evseev assigned praries880 and unassigned anton-evseev Aug 31, 2018

praries880 added the Waiting for On Demand label Aug 31, 2018

praries880 approved these changes Aug 31, 2018

View reviewed changes

praries880 added Waiting for CI and removed needs-revision labels Aug 31, 2018

praries880 merged commit f6a2882 into Azure:preview Aug 31, 2018

anton-evseev deleted the preview-with-nrp-august branch September 3, 2018 05:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge NRP's August branch in preview #7113

Merge NRP's August branch in preview #7113

Uh oh!

anton-evseev commented Aug 31, 2018

Uh oh!

praries880 Aug 31, 2018

Uh oh!

praries880 Aug 31, 2018

Uh oh!

Uh oh!

Uh oh!

praries880 Aug 31, 2018

Uh oh!

praries880 Aug 31, 2018

Uh oh!

praries880 Aug 31, 2018

Uh oh!

anton-evseev Aug 31, 2018

Uh oh!

praries880 Aug 31, 2018

Uh oh!

anton-evseev Aug 31, 2018

Uh oh!

praries880 Aug 31, 2018

Uh oh!

praries880 commented Aug 31, 2018

Uh oh!

praries880 commented Aug 31, 2018

Uh oh!

praries880 commented Aug 31, 2018

Uh oh!

praries880 left a comment

Uh oh!

Uh oh!

Merge NRP's August branch in preview #7113

Merge NRP's August branch in preview #7113

Uh oh!

Conversation

anton-evseev commented Aug 31, 2018

Description

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

praries880 commented Aug 31, 2018

Uh oh!

praries880 commented Aug 31, 2018

Uh oh!

praries880 commented Aug 31, 2018

Uh oh!

praries880 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!