Adding stack package folders path for cleanup #7159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathly809
reviewed
Sep 7, 2018
tools/CleanupBuild.ps1
Outdated
|
|
||
| $acceptedDlls = @() | ||
| $acceptedDlls += $ModuleMetadata.NestedModules | ||
| $acceptedDlls += $ModuleMetadata.RequiredAssemblies |
There was a problem hiding this comment.
We don't fill this in, we need to do a PR to add these.
deathly809
suggested changes
Sep 7, 2018
|
Tests are broken. I have messed up something.. :( |
|
@deathly809 Did you publish your review? I dont see the comments |
|
@deathly809 I see it, I have added the requred assemblies |
deathly809
reviewed
Sep 10, 2018
deathly809
previously approved these changes
Sep 10, 2018
…ules to stack package folder
|
Rikicked ps-sign after Compute PR got merged, |
|
Checked over dlls in ResourceManager and they look correct. Passing Travis job is here: https://travis-ci.org/Azure/azure-powershell/builds/426798935, merging now. |
maddieclayton
approved these changes
Sep 11, 2018
ionuttulai
pushed a commit
to ionuttulai/azure-powershell
that referenced
this pull request
Mar 4, 2020
Adding stack package folders path for cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stack modules were having unwanted dlls, adding the removal of them in the existing clean up script.
Checklist
CONTRIBUTING.mdplatyPSmodule