Powershell for interface endpoints #7172

chandrasekarsrinivasan · 2018-09-09T19:12:52Z

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

chandrasekarsrinivasan · 2018-09-09T19:20:54Z

src/ResourceManager/Network/Commands.Network.Test/Commands.Network.Test.csproj

@@ -43,8 +43,8 @@
    <RunCodeAnalysis>false</RunCodeAnalysis>
  </PropertyGroup>
  <ItemGroup>
-    <Reference Include="Microsoft.Azure.Management.Network, Version=19.0.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\Microsoft.Azure.Management.Network.19.3.0-preview\lib\net452\Microsoft.Azure.Management.Network.dll</HintPath>
+    <Reference Include="Microsoft.Azure.Management.Network, Version=19.5.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


Add readme file for interface endpoints

maddieclayton · 2018-09-10T19:38:09Z

@chandrasekarsrinivasan Please either fill out or link a cmdlet design review here: https://github.com/Azure/azure-powershell-cmdlet-review-pr

praries880 · 2018-09-10T19:41:06Z

design review : https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/152

praries880 · 2018-09-10T19:43:38Z

@chandrasekarsrinivasan fix CI issues :

https://travis-ci.org/Azure/azure-powershell/builds/426415071#L1125
https://azuresdkci.westus2.cloudapp.azure.com/job/powershell/7307/console :
- 12:54:59 CSC : error CS2001: Source file 'c:\workspace\powershell\src\ResourceManager\Network\Commands.Network\InterfaceEndpoint\GetAzureServiceEndpointPolicyCommand.cs' could not be found. [c:\workspace\powershell\src\ResourceManager\Network\Commands.Network\Commands.Network.csproj]

praries880 · 2018-09-10T19:58:45Z

@chandrasekarsrinivasan you need to generate the help file for the cmdlet you added here.

praries880 · 2018-09-12T20:31:43Z

@chandrasekarsrinivasan kindly merge form the september branch to resolve conflicts

praries880 · 2018-09-13T16:31:08Z

src/ResourceManager/Network/Commands.Network/ChangeLog.md

@@ -45,6 +45,7 @@
 ## Version 6.7.0
 * Updated cmdlet New-AzureRmVirtualNetworkGatewayConnection with support for switch ExpressRouteGatewayBypass
 * Added cmdlets for Azure SdWan
+* Add cmdlet for Interface Endpoint Get-AzureInterfaceEndpoint


@chandrasekarsrinivasan this needs to be under Current Release

praries880 · 2018-09-13T18:13:23Z

@chandrasekarsrinivasan merge conflicts need to be resolved

praries880 · 2018-09-13T18:45:41Z

src/ResourceManager/Profile/Commands.Profile/AzureRmAlias/Mappings.cs

@@ -1045,7 +1045,8 @@ public class Mappings
                       'Get-AzApplicationGatewayUrlPathMapConfig':  'Get-AzureRmApplicationGatewayUrlPathMapConfig',
                       'Get-AzNetworkWatcherConnectionMonitor':  'Get-AzureRmNetworkWatcherConnectionMonitor',
                       'Remove-AzVirtualNetworkSubnetConfig':  'Remove-AzureRmVirtualNetworkSubnetConfig',
-                       'Get-AzBgpServiceCommunity':  'Get-AzureRmBgpServiceCommunity'
+                       'Get-AzBgpServiceCommunity':  'Get-AzureRmBgpServiceCommunity',
+                       'Get-AzInterfaceEndpoint':  'Get-AzInterfaceEndpoint',


there is something wrong here...
It should be
'Get-AzInterfaceEndpoint': 'Get-AzureRmInterfaceEndpoint',

praries880 · 2018-09-13T18:48:13Z

...sourceManager/Network/Commands.Network/InterfaceEndpoint/GetAzureInterfaceEndpointCommand.cs

+    using System.Collections.Generic;
+    using System.Management.Automation;
+
+    [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "InterfaceEndpoint", SupportsShouldProcess = true, DefaultParameterSetName = "GetByNameParameterSet"), OutputType(typeof(PSInterfaceEndpoint))]


you need to adda test case for this cmdlet. There is not test case in the PR

We cannot have a test case on this. there is no way to test.

Further details - we are not ready to expose end to end scenario for this through powershell. There is no way to set this on PS and hence a test case cannot be created. In a couple of months, we will have full support on this and then we can create New-, Set- APIs.

praries880 · 2018-09-13T18:49:51Z

marking as Do Not Merge as the PR is missing attest case for the new cmdlet

praries880 · 2018-09-13T19:47:56Z

@chandrasekarsrinivasan kindly take care of merge conflicts

praries880 · 2018-09-13T20:25:06Z

cancelled CI as it would free up the worker and we don't need the current job to complete as the PR is going to be updated

chandrasekarsrinivasan commented Sep 9, 2018

View reviewed changes

azuresdkci1x added the needs-review label Sep 9, 2018

praries880 self-assigned this Sep 10, 2018

praries880 added the Cmdlet Review Required ⚠️ label Sep 10, 2018

cormacpayne added needs-revision and removed needs-review labels Sep 11, 2018

cormacpayne assigned chandrasekarsrinivasan and unassigned praries880 Sep 11, 2018

maddieclayton removed the needs-revision label Sep 11, 2018

chandrasekarsrinivasan force-pushed the interfaceendpoints branch 3 times, most recently from 791b832 to 4688934 Compare September 12, 2018 05:26

praries880 added needs-revision Cmdlet Review Complete and removed Cmdlet Review Required ⚠️ labels Sep 12, 2018

maddieclayton assigned praries880 Sep 12, 2018

maddieclayton added the Merge Conflicts label Sep 12, 2018

chandrasekarsrinivasan force-pushed the interfaceendpoints branch 2 times, most recently from 7cffd4a to 3f79bb7 Compare September 13, 2018 05:32

EvgenyAgafonchikov force-pushed the interfaceendpoints branch from d72e508 to 5e46bf7 Compare September 13, 2018 09:02

praries880 reviewed Sep 13, 2018

View reviewed changes

chandrasekarsrinivasan force-pushed the interfaceendpoints branch from 5e46bf7 to cbc8bf3 Compare September 13, 2018 18:10

chandrasekarsrinivasan force-pushed the interfaceendpoints branch from cbc8bf3 to 5383690 Compare September 13, 2018 18:32

praries880 reviewed Sep 13, 2018

View reviewed changes

praries880 suggested changes Sep 13, 2018

View reviewed changes

praries880 added Do Not Merge 🚫 and removed Merge Conflicts labels Sep 13, 2018

chandrasekarsrinivasan force-pushed the interfaceendpoints branch from 5383690 to 1e2579b Compare September 13, 2018 19:22

praries880 removed the Do Not Merge 🚫 label Sep 13, 2018

praries880 previously approved these changes Sep 13, 2018

View reviewed changes

praries880 added Waiting for CI Merge Conflicts and removed needs-revision labels Sep 13, 2018

Interface endpoints

801bf01

chandrasekarsrinivasan dismissed praries880’s stale review via 801bf01 September 13, 2018 20:26

chandrasekarsrinivasan force-pushed the interfaceendpoints branch from 1e2579b to 801bf01 Compare September 13, 2018 20:26

praries880 approved these changes Sep 13, 2018

View reviewed changes

markcowl removed the Merge Conflicts label Sep 13, 2018

markcowl merged commit 8939a4b into Azure:network-september-release Sep 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Powershell for interface endpoints #7172

Powershell for interface endpoints #7172

Uh oh!

chandrasekarsrinivasan commented Sep 9, 2018

Uh oh!

chandrasekarsrinivasan Sep 9, 2018

Uh oh!

maddieclayton commented Sep 10, 2018

Uh oh!

praries880 commented Sep 10, 2018

Uh oh!

praries880 commented Sep 10, 2018 •

edited

Loading

Uh oh!

praries880 commented Sep 10, 2018

Uh oh!

praries880 commented Sep 12, 2018

Uh oh!

praries880 Sep 13, 2018 •

edited

Loading

Uh oh!

praries880 commented Sep 13, 2018

Uh oh!

praries880 Sep 13, 2018

Uh oh!

praries880 Sep 13, 2018

Uh oh!

chandrasekarsrinivasan Sep 13, 2018

Uh oh!

chandrasekarsrinivasan Sep 13, 2018

Uh oh!

praries880 commented Sep 13, 2018

Uh oh!

praries880 commented Sep 13, 2018

Uh oh!

praries880 commented Sep 13, 2018

Uh oh!

Uh oh!

Powershell for interface endpoints #7172

Powershell for interface endpoints #7172

Uh oh!

Conversation

chandrasekarsrinivasan commented Sep 9, 2018

Description

Checklist

Uh oh!

chandrasekarsrinivasan Sep 9, 2018

Choose a reason for hiding this comment

Uh oh!

maddieclayton commented Sep 10, 2018

Uh oh!

praries880 commented Sep 10, 2018

Uh oh!

praries880 commented Sep 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

praries880 commented Sep 10, 2018

Uh oh!

praries880 commented Sep 12, 2018

Uh oh!

praries880 Sep 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

praries880 commented Sep 13, 2018

Uh oh!

praries880 Sep 13, 2018

Choose a reason for hiding this comment

Uh oh!

praries880 Sep 13, 2018

Choose a reason for hiding this comment

Uh oh!

chandrasekarsrinivasan Sep 13, 2018

Choose a reason for hiding this comment

Uh oh!

chandrasekarsrinivasan Sep 13, 2018

Choose a reason for hiding this comment

Uh oh!

praries880 commented Sep 13, 2018

Uh oh!

praries880 commented Sep 13, 2018

Uh oh!

praries880 commented Sep 13, 2018

Uh oh!

Uh oh!

praries880 commented Sep 10, 2018 •

edited

Loading

praries880 Sep 13, 2018 •

edited

Loading