Skip to content

Order of Operations for OVPN test #7185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2018

Conversation

henry416
Copy link
Member

Description

Fix for ovpn test to go in proper order of operations as expected by preview instructions

Checklist

@henry416 henry416 closed this Sep 10, 2018
@henry416 henry416 reopened this Sep 10, 2018
@henry416 henry416 changed the base branch from AzureRM.Network-preview to network-september-release September 10, 2018 23:09
markcowl
markcowl previously approved these changes Sep 10, 2018
@maddieclayton
Copy link
Contributor

@henry416
Copy link
Member Author

@maddieclayton looks like run with wrong API version, I will correct this

@henry416
Copy link
Member Author

Failure doesn't seem related to test

@cormacpayne
Copy link
Member

@henry416 Hey Henry, the build is failing after CredScan flagged a few files for containing potential passwords, secrets, keys, etc. You can find the results here: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell/7369/artifact/src/Package/CredentialScannerOutput/CredScanIssues.csv

Would you mind taking a look at the files that were flagged and ensure that these are values that anyone else can use? (i.e., they are dummy values or have been deleted since the recording) If it turns out this is the case, we can suppress these exceptions (using the method outlined here).

@henry416
Copy link
Member Author

@cormacpayne This is a false positive cred, I have updated the file to try to suppress it.

@henry416
Copy link
Member Author

On request of @MikhailTryakhov, updated the route API test record as well

@maddieclayton maddieclayton merged commit d3c50b6 into Azure:network-september-release Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants