Allow Az to run on Desktop and ClientRuntime update #7214

markcowl · 2018-09-12T04:07:22Z

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

…ft9merge

src/TestPrerequisites/Common.Test.Prerequisites/Common.TestPrerequisites.csproj

markcowl · 2018-09-12T16:57:43Z

on demand: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/1092/

signing:https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/1272/

netsign: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/psnetsign/184/

MiYanni · 2018-09-12T20:38:09Z

.travis.yml

@@ -25,9 +25,10 @@ before_install:
 # https://github.com/travis-ci/travis-ci/issues/1066#issuecomment-383489298
 script:
 - sudo dotnet msbuild build.proj /t:BuildNetcore /p:Configuration=$CONFIG || travis_terminate 1
- - sudo dotnet tools/StaticAnalysis/bin/$CONFIG/netcoreapp2.1/StaticAnalysis.Netcore.dll -p src/Package/$CONFIG -r src/Package -u || travis_terminate 1
+ - sudo dotnet tools/StaticAnalysis/bin/$CONFIG/netcoreapp2.1/StaticAnalysis.Netcore.dll -p src/Package/$CONFIG -r src/Package -u 


Please keep || travis_terminate 1 as this allows the build to stop and fail when static analysis fails.

MiYanni · 2018-09-12T20:41:25Z

src/ResourceManager/Aks/Commands.Aks/Commands.Aks.Netcore.csproj

@@ -12,6 +12,7 @@
    <OutputPath>$(ProjectDir)..\..\..\Package\$(Configuration)\ResourceManager\AzureResourceManager\Az.Aks\</OutputPath>
    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
    <WarningsAsErrors />
+    <Version>1.1.0.0</Version>


What is this version for?

MiYanni · 2018-09-12T20:41:44Z

src/ResourceManager/Aks/Commands.Aks/Properties/AssemblyInfo.cs

-[assembly: AssemblyVersion("0.0.5")]
-[assembly: AssemblyFileVersion("0.0.5")]
+[assembly: AssemblyVersion("0.0.6")]
+[assembly: AssemblyFileVersion("0.0.6")]


Assembly version number change???

no good reason

MiYanni · 2018-09-12T20:54:20Z

src/ResourceManager/Sql/LegacySdk/SqlManagement.Netcore.csproj

+  <PropertyGroup>
+    <OmitJsonPackage>true</OmitJsonPackage>
+  </PropertyGroup>
+


Why remove the common targets and then reference the targets by hand? Also, looks like it would have worked if you put the <OmitJsonPackage> above the common Import. Order matters.

Because this is a captured Hyak library - it doesn't require 90% of the dependencies in the common targets, just the runtime modules related to Hyak

there's no reason to use OmitJsonPackage here if we aren't using the common targets, however.

I think I was stripping this to bare bones (because it is a captured Hyak library) to try to debug an issue and didn't put it back. Will try using the common pacjage and letting the compiler decide on dependencies.

It just makes it easier updating those packages to not have one-off files.

src/TestPrerequisites/Common.Test.Prerequisites/Common.TestPrerequisites.csproj

…uild

markcowl · 2018-09-13T06:41:40Z

ps sign: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/1282/

ps netsign: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/psnetsign/186/

MiYanni

LGTM

v-shresh · 2018-09-13T13:20:25Z

Hi All Please stop marking me in this email. I have got almost 2185 emails and my email account has been clogged now. Thanks Shreya From: Michael Yanni [mailto:[email protected]] Sent: Thursday, September 13, 2018 6:32 PM To: Azure/azure-powershell <[email protected]> Cc: Subscribed <[email protected]> Subject: Re: [Azure/azure-powershell] Allow Az to run on Desktop and ClientRuntime update (#7214) @MiYanni approved this pull request. LGTM — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fi.8713187.xyz%2FAzure%2Fazure-powershell%2Fpull%2F7214%23pullrequestreview-155068511&data=02%7C01%7Cv-shresh%40microsoft.com%7C9a4e7e4d895e4c50376408d6197907bc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636724404946760291&sdata=gxDggbSr1%2Fry7efiPG0IlH75kYVxmCR%2F33beu6HM%2FR4%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fi.8713187.xyz%2Fnotifications%2Funsubscribe-auth%2FAGDq4X0rCS0OHDjbGbBOojtIyr_oSeXDks5ualcsgaJpZM4WknQE&data=02%7C01%7Cv-shresh%40microsoft.com%7C9a4e7e4d895e4c50376408d6197907bc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636724404946770295&sdata=1DuPSOjES25y6dW68vV6dkx3ETTxiNoVpLOESGsoqU8%3D&reserved=0>.

cormacpayne · 2018-09-13T15:59:05Z

@v-shresh you are probably receiving emails from our repository (and other Azure repositories) due to how your GitHub notification settings are configured. Please click on your icon in the top right corner, select "Settings" and go to the "Notifications" page to configure when and how you receive notifications from GitHub.

markcowl added 16 commits August 30, 2018 15:24

Use Newtonsoft.Json version 9

0b01c42

Update auth package to newtonsoft.Json 10

0612345

nsoft 9

019194a

Update for nsoft dependencies

65aeafd

Update tooling packages

f94b94b

Cleaning up dependency packages

891e512

Changes for newtonsoft depednency

b3dfb31

Update test infrastructure for net472 build

43d6a0d

Updating tests for assembly loading

ec04c37

Update powershell for new packages

d92861d

Merge branch 'preview' of github.com:/azure/azure-powershell into nso…

c67b541

…ft9merge

Updating common packages

4f3e444

update runtime versions

eb91126

Merge fixes

86ec9d7

Simplifying storage dependency

0729f6c

Test and build fixes

ee9e7ff

markcowl added the Do Not Merge 🚫 label Sep 12, 2018

azuresdkci1x added the needs-review label Sep 12, 2018

markcowl added 7 commits September 11, 2018 23:15

Move artifacts target folder

8b9e93a

Adding storage dependencies in profile module

56a78fc

Add storage dll copying

083748f

Update package target for test prerequisites

ecdea21

Update for storage differences

676d7e3

Merge branch 'preview' of github.com:/azure/azure-powershell into nso…

fa09303

…ft9merge

Fixing bad merge in Stack directory

5df858d

markcowl commented Sep 12, 2018

View reviewed changes

src/TestPrerequisites/Common.Test.Prerequisites/Common.TestPrerequisites.csproj Show resolved Hide resolved

Remove inadvertent changes to StackAdmin files

2443d69

maddieclayton assigned cormacpayne and MiYanni Sep 12, 2018

Putting back AzureRM.psm1

5d8015c

MiYanni suggested changes Sep 12, 2018

View reviewed changes

MiYanni added the needs-revision label Sep 12, 2018

maddieclayton added Ignite and removed needs-review labels Sep 12, 2018

markcowl added 2 commits September 12, 2018 22:56

Merging with upstream

979bcef

Respond to review comments and allow prebuild assemblies in cleanup b…

22290ce

…uild

MiYanni previously approved these changes Sep 13, 2018

View reviewed changes

cormacpayne previously approved these changes Sep 13, 2018

View reviewed changes

Using common packages from myget feed

f580c7d

markcowl dismissed stale reviews from cormacpayne and MiYanni via f580c7d September 13, 2018 18:40

MiYanni approved these changes Sep 13, 2018

View reviewed changes

markcowl merged commit cbd6dee into Azure:preview Sep 13, 2018

Allow Az to run on Desktop and ClientRuntime update #7214

Allow Az to run on Desktop and ClientRuntime update #7214

Uh oh!

Conversation

markcowl commented Sep 12, 2018

Description

Checklist

Uh oh!

Uh oh!

markcowl commented Sep 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

markcowl commented Sep 13, 2018

Uh oh!

MiYanni left a comment

Choose a reason for hiding this comment

Uh oh!

v-shresh commented Sep 13, 2018 via email

Uh oh!

cormacpayne commented Sep 13, 2018

Uh oh!

Uh oh!

markcowl commented Sep 12, 2018 •

edited

Loading