Adding support for security provider integration in cortex cmdlets. #7261

nalinrajgupta · 2018-09-14T23:15:00Z

Description

Adding support for security provider integration in cortext.
Customer can provide SecurityProviderName and Offic365LocalBreakoutCategory when creating/updating VirtualWan object.
Customer can also provide/update EnbleInternetSecurity flag in VpnConnection and VirtualHubVnetConnection.

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

nalinrajgupta · 2018-09-14T23:35:00Z

Powershell document review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/123

adxsdkps · 2018-09-14T23:37:10Z

Can one of the admins verify this patch?

maddieclayton · 2018-09-17T21:22:30Z

@azuresdkci Add to whitelist

...Commands.Network/Cortex/HubVnetConnection/UpdateAzureRmHubVirtualNetworkConnectionCommand.cs

maddieclayton · 2018-09-17T23:51:57Z

...Commands.Network/Cortex/HubVnetConnection/UpdateAzureRmHubVirtualNetworkConnectionCommand.cs

+
+        [Alias("VirtualHubName", "ParentVirtualHubName")]
+        [Parameter(
+            Mandatory = false,


This should be mandatory

...Commands.Network/Cortex/HubVnetConnection/UpdateAzureRmHubVirtualNetworkConnectionCommand.cs

maddieclayton · 2018-09-17T23:52:46Z

...Commands.Network/Cortex/HubVnetConnection/UpdateAzureRmHubVirtualNetworkConnectionCommand.cs

+        public override void Execute()
+        {
+            base.Execute();
+            WriteWarning("The output object type of this cmdlet will be modified in a future release.");


Please remove this line

...Commands.Network/Cortex/HubVnetConnection/UpdateAzureRmHubVirtualNetworkConnectionCommand.cs

src/ResourceManager/Network/Commands.Network/Cortex/VirtualWan/NewAzureRmVirtualWanCommand.cs

...ourceManager/Network/Commands.Network/help/Get-AzureRmVirtualWanSupportedSecurityProvider.md

src/ResourceManager/Network/Commands.Network/AzureRM.Network.psd1

...Commands.Network/Cortex/HubVnetConnection/UpdateAzureRmHubVirtualNetworkConnectionCommand.cs

src/ResourceManager/Network/Commands.Network/ChangeLog.md

maddieclayton · 2018-09-18T20:15:28Z

@nalinrajgupta Please ping me when you are ready for me to take another look.

nalinrajgupta · 2018-09-18T21:11:42Z

@maddieclayton : I've resolved all comments, can you please take a look ?

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/CortexTests.ps1

...Commands.Network/Cortex/HubVnetConnection/UpdateAzureRmHubVirtualNetworkConnectionCommand.cs

maddieclayton · 2018-09-18T23:20:03Z

@nalinrajgupta One small comment, then once the test is rerecorded we can merge.

maddieclayton · 2018-09-19T21:37:38Z

@nalinrajgupta Please ping me when you get this test recording in, and I'll take a final look.

nalinrajgupta · 2018-09-20T16:41:24Z

@maddieclayton : I've resolved all comments and recorded tests also. Can you please take a look ?

maddieclayton

Two very small comment I didn't catch next time, then this is ready to go.

...k/Commands.Network/Cortex/VirtualWan/GetAzureRmVirtualWanSupportedSecurityProviderCommand.cs

src/ResourceManager/Network/Commands.Network/help/Update-AzureRmVirtualHubVnetConnection.md

...Commands.Network/Cortex/HubVnetConnection/UpdateAzureRmHubVirtualNetworkConnectionCommand.cs

nalinrajgupta · 2018-09-20T23:59:47Z

@maddieclayton : Can you please approve the PR ? All validations has passed now.

maddieclayton · 2018-09-21T00:18:49Z

@nalinrajgupta Can you regenerate the help files one more time? It looks like the Update-AzureRmVirtualHubVnetConnection parameter sets are wrong (InputObject is optional, ResourceId is optional), but it's correct in the actual cs file. That's my only remaining comment.

Nalin Gupta added 4 commits September 13, 2018 16:18

Adding support for security provider integration.

7d40f13

Adding help files.

5f248bf

Fixing build error.

26a5a16

Merging with Azure/AzureRM.Network-preview

9a45366

nalinrajgupta changed the title ~~Cortex: Adding support for security provider integration.~~ Adding support for security provider integration in cortex cmdlets. Sep 14, 2018

Adding changelog.

01aee94

nalinrajgupta requested a review from maddieclayton September 14, 2018 23:26

maddieclayton self-assigned this Sep 14, 2018

nalinrajgupta requested a review from ritwikbasu September 14, 2018 23:26

maddieclayton added Preview needs-review 👀 needs-review and removed needs-review 👀 labels Sep 14, 2018

azuresdkci1x added the needs-review label Sep 14, 2018

maddieclayton suggested changes Sep 18, 2018

View reviewed changes

maddieclayton added needs-revision and removed needs-review labels Sep 18, 2018

maddieclayton assigned nalinrajgupta and unassigned maddieclayton Sep 18, 2018

Nalin Gupta added 5 commits September 18, 2018 10:50

Resolving comments.

d506b0e

Resolving help file comment.

6d36fa7

Reverting back unnessary change.

78e2d20

Merging with latest.

9babcd9

Resolving more comments.

28c24d7

maddieclayton suggested changes Sep 18, 2018

View reviewed changes

Resovling more comments.

8e27d5a

Resolving all comments.

4b8e8c9

maddieclayton suggested changes Sep 18, 2018

View reviewed changes

src/ResourceManager/Network/Commands.Network.Test/ScenarioTests/CortexTests.ps1 Outdated Show resolved Hide resolved

...Commands.Network/Cortex/HubVnetConnection/UpdateAzureRmHubVirtualNetworkConnectionCommand.cs Outdated Show resolved Hide resolved

Fixing more comments.

6574078

Recording test.

b264e8a

maddieclayton suggested changes Sep 20, 2018

View reviewed changes

...k/Commands.Network/Cortex/VirtualWan/GetAzureRmVirtualWanSupportedSecurityProviderCommand.cs Outdated Show resolved Hide resolved

src/ResourceManager/Network/Commands.Network/help/Update-AzureRmVirtualHubVnetConnection.md Outdated Show resolved Hide resolved

Nalin Gupta added 2 commits September 20, 2018 11:38

Resolving more comments.

82e5c10

Adding recorede test to cred scan exception.

933aa2b

maddieclayton suggested changes Sep 20, 2018

View reviewed changes

...Commands.Network/Cortex/HubVnetConnection/UpdateAzureRmHubVirtualNetworkConnectionCommand.cs Outdated Show resolved Hide resolved

More.

8d302f3

Correcting help file.

530e6e9

maddieclayton assigned maddieclayton and unassigned nalinrajgupta Sep 21, 2018

maddieclayton added Waiting for CI and removed needs-revision labels Sep 21, 2018

maddieclayton approved these changes Sep 21, 2018

View reviewed changes

maddieclayton merged commit 8e11016 into Azure:AzureRM.Network-preview Sep 21, 2018

nagula-ritvika mentioned this pull request Oct 17, 2019

Adding cmdltets to support crud operations for new Route Table child resource of VirtualHub #10317

Merged

8 tasks

Adding support for security provider integration in cortex cmdlets. #7261

Adding support for security provider integration in cortex cmdlets. #7261

Uh oh!

Conversation

nalinrajgupta commented Sep 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

nalinrajgupta commented Sep 14, 2018

Uh oh!

adxsdkps commented Sep 14, 2018

Uh oh!

maddieclayton commented Sep 17, 2018

Uh oh!

Uh oh!

maddieclayton Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

maddieclayton Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maddieclayton commented Sep 18, 2018

Uh oh!

nalinrajgupta commented Sep 18, 2018

Uh oh!

Uh oh!

Uh oh!

maddieclayton commented Sep 18, 2018

Uh oh!

maddieclayton commented Sep 19, 2018

Uh oh!

nalinrajgupta commented Sep 20, 2018

Uh oh!

maddieclayton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nalinrajgupta commented Sep 20, 2018

Uh oh!

maddieclayton commented Sep 21, 2018

Uh oh!

Uh oh!

nalinrajgupta commented Sep 14, 2018 •

edited

Loading