Skip to content

Fix how output and generic types are checked in the breaking change tool #7273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

cormacpayne
Copy link
Member

@cormacpayne cormacpayne commented Sep 17, 2018

Description

Fix for #7151

Change how the breaking change tool validates output and generic type changes by checking more than just the name of the type.

Checklist

@cormacpayne
Copy link
Member Author

@markcowl @maddieclayton @MiYanni would someone mind reviewing this when they get the chance? 😀

Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... But, my boy, I needa teach you some good ol' data-driven design logic. Imperative logic is so old school. With the way this is built, you could likely make a map of predicates to values for checking most of the scenarios. Then, you'd likely only have one (or very few) calls to LogBreakingChangeIssue since you just inject the values needed for the call. It works similar to dependency injection. Either way, this PR is fineo for the mergeo. 🌮

@cormacpayne cormacpayne merged commit 41be466 into Azure:preview Sep 25, 2018
@cormacpayne cormacpayne deleted the type-check-refactor branch October 15, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants