Allow any string as Size parameter going forward. Add P5 in PSArgumen… #7306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2018 15:33
cormacpayne
suggested changes
Sep 20, 2018
| @@ -0,0 +1,21 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
@SiddharthChatrolaMs this file isn't necessary -- the existing change log for RedisCache can be found here.
There was a problem hiding this comment.
This is fixed
| [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Size of redis cache. Valid values: P1,P2, P3, P4, C0, C1, C2, C3, C4, C5, C6, 250MB, 1GB, 2.5GB, 6GB, 13GB, 26GB, 53GB")] | ||
| [ValidateSet(SizeConverter.P1String, SizeConverter.P2String, SizeConverter.P3String, SizeConverter.P4String, | ||
| [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, HelpMessage = "Size of redis cache. Valid values: P1,P2, P3, P4, P5, C0, C1, C2, C3, C4, C5, C6, 250MB, 1GB, 2.5GB, 6GB, 13GB, 26GB, 53GB, 120GB")] | ||
| [PSArgumentCompleter(SizeConverter.P1String, SizeConverter.P2String, SizeConverter.P3String, SizeConverter.P4String, SizeConverter.P5String, |
There was a problem hiding this comment.
@SiddharthChatrolaMs any test functionality for the new values to ensure that they work on the server?
There was a problem hiding this comment.
We wanted to make this parameter string so whenever we have new Sku, customers can create new caches without PowerShell update. Existing tests would be enough for that. As we don't test all of the values provided here
|
@cormacpayne Fixed one comment and replied to another one |
cormacpayne
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tCompleter popup
Description
Checklist
CONTRIBUTING.mdplatyPSmodule