What if support #7308
What if support #7308
Conversation
| @@ -19,6 +19,8 @@ | |||
| ---> | |||
|
|
|||
| ## Current Release | |||
| * Added WhatIf support to Get-AzureRmNetworkSecurityGroup | |||
There was a problem hiding this comment.
this is not required. Should Process is only required for cmdlets that have server side effects. Gets do not do that and hence are not candidates for shouldprocess. Kindly revert this.
| @@ -22,7 +22,7 @@ | |||
|
|
|||
| namespace Microsoft.Azure.Commands.Network | |||
| { | |||
| [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "NetworkSecurityGroup"), OutputType(typeof(PSNetworkSecurityGroup))] | |||
| [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "NetworkSecurityGroup", SupportsShouldProcess = true), OutputType(typeof(PSNetworkSecurityGroup))] | |||
There was a problem hiding this comment.
this is not required. Should Process is only required for cmdlets that have server side effects. Gets do not do that and hence are not candidates for shouldprocess. Kindly revert this.
| @@ -16,13 +16,13 @@ Gets a network security group. | |||
| ### NoExpand | |||
| ``` | |||
| Get-AzureRmNetworkSecurityGroup [-Name <String>] [-ResourceGroupName <String>] | |||
| [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>] | |||
| [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>] | |||
There was a problem hiding this comment.
this is not required. Should Process is only required for cmdlets that have server side effects. Gets do not do that and hence are not candidates for shouldprocess. Kindly revert this.
| ``` | ||
|
|
||
| ### Expand | ||
| ``` | ||
| Get-AzureRmNetworkSecurityGroup -Name <String> -ResourceGroupName <String> -ExpandResource <String> | ||
| [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>] | ||
| [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>] |
There was a problem hiding this comment.
this is not required. Should Process is only required for cmdlets that have server side effects. Gets do not do that and hence are not candidates for shouldprocess. Kindly revert this.
| @@ -43,7 +43,7 @@ This command returns contents of Azure network security group "nsg1" in resource | |||
| The credentials, account, tenant, and subscription used for communication with azure. | |||
|
|
|||
| ```yaml | |||
| Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.IAzureContextContainer | |||
| Type: IAzureContextContainer | |||
There was a problem hiding this comment.
You'll need to regenerate the help files.
Remember to use the flag -UseFullTypeName when you generate the help files. instructions here.
| @@ -37,7 +37,7 @@ The command persists the modified Azure network security group using **Set-Azure | |||
| Run cmdlet in the background | |||
|
|
|||
| ```yaml | |||
| Type: System.Management.Automation.SwitchParameter | |||
| Type: SwitchParameter | |||
There was a problem hiding this comment.
You'll need to regenerate the help files.
Remember to use the flag -UseFullTypeName when you generate the help files. instructions here.
|
@wdehrich kindly take care of the review comments |
Description
Checklist
CONTRIBUTING.mdplatyPSmodule