-
Notifications
You must be signed in to change notification settings - Fork 4k
Make alias mapping more simple #7320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
'Set-AzSqlDatabaseAuditingPolicy': 'Set-AzureRmSqlDatabaseAuditingPolicy', | ||
'Get-AzSqlServerBackupLongTermRetentionVault': 'Get-AzureRmSqlServerBackupLongTermRetentionVault', | ||
'Update-AzSqlSyncGroup': 'Update-AzureRmSqlSyncGroup', | ||
'Remove-AzSqlElasticPool': 'Remove-AzureRmSqlElasticPoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still a bit confused... If we made this mapping a json file and included it in our Profile package, wouldn't that work just as well and be significantly easier to understand/maintain? Writing C# code using PowerShell seems a bit over-the-top. Both C# and PowerShell can load the json file and use it as needed.
@MiYanni Done, please take another look - CI will now automatically update the json file instead of the cs file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd have to change the Profile .csproj for it to actually include the Mappings.json file. Otherwise, this won't run on someone's machine, right? The file needs to exist for the cmdlet to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Checklist
CONTRIBUTING.md
platyPS
module