Skip to content

Make alias mapping more simple #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 25, 2018
Merged

Make alias mapping more simple #7320

merged 10 commits into from
Sep 25, 2018

Conversation

maddieclayton
Copy link
Contributor

Description

Checklist

maddieclayton added 2 commits September 20, 2018 15:24
'Set-AzSqlDatabaseAuditingPolicy': 'Set-AzureRmSqlDatabaseAuditingPolicy',
'Get-AzSqlServerBackupLongTermRetentionVault': 'Get-AzureRmSqlServerBackupLongTermRetentionVault',
'Update-AzSqlSyncGroup': 'Update-AzureRmSqlSyncGroup',
'Remove-AzSqlElasticPool': 'Remove-AzureRmSqlElasticPoo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a bit confused... If we made this mapping a json file and included it in our Profile package, wouldn't that work just as well and be significantly easier to understand/maintain? Writing C# code using PowerShell seems a bit over-the-top. Both C# and PowerShell can load the json file and use it as needed.

@maddieclayton
Copy link
Contributor Author

@MiYanni Done, please take another look - CI will now automatically update the json file instead of the cs file.

Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd have to change the Profile .csproj for it to actually include the Mappings.json file. Otherwise, this won't run on someone's machine, right? The file needs to exist for the cmdlet to work.

Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maddieclayton maddieclayton merged commit a7e9bd2 into Azure:preview Sep 25, 2018
@maddieclayton maddieclayton deleted the updatemappings branch September 25, 2018 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants