Skip to content

NetStandard Tests v1 #7383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 3, 2018
Merged

NetStandard Tests v1 #7383

merged 12 commits into from
Oct 3, 2018

Conversation

MiYanni
Copy link
Contributor

@MiYanni MiYanni commented Sep 25, 2018

Description

v1 set of Az tests from this issue: #6931

Checklist

@cormacpayne
Copy link
Member

@MiYanni looks like there's a path issue with one of the ServiceFabric tests -- would you mind taking a look?

Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiYanni changes look good to me, but I'd like @markcowl to take a look as well

@cormacpayne cormacpayne assigned markcowl and unassigned cormacpayne Sep 27, 2018
@MiYanni MiYanni mentioned this pull request Oct 2, 2018
8 tasks
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the comment on skips

@MiYanni MiYanni merged commit 9875e98 into Azure:preview Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants