-
Notifications
You must be signed in to change notification settings - Fork 4k
FW: Adding cmdlets for creating and deleting AD application & service principal #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge public master
Added service objective information to Database object. Ensured exclusivity of parameters for get database operation
merge from azure/azure-powershell/dev
…to dev-sql-fixes
…to dev-sql-fixes
Add new cmdlets for storage SAS token stored policy.
Dev sql fixes
servicePrincipal
Can one of the admins verify this patch? |
Hi @perseusCode, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
add to whitelist |
[Cmdlet(VerbsCommon.New, "AzureADApplication", DefaultParameterSetName = ParameterSet.ApplicationWithoutCredential), OutputType(typeof(PSADApplication))] | ||
public class NewAzureADApplicationCommand : ActiveDirectoryBaseCmdlet | ||
{ | ||
private string _KeyType = "AsymmetricX509Cert"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we don't use _
convention in PowerShell
Merge master -> dev for release -0.8.13
Merge master -> dev for release 0.8.13
servicePrincipal
Upgrade to use latest common packages
Update Azure PowerShell to depend on Hyak.Common
retest this please |
Didn't get your comment, do you want me to run the unit tests again ? |
@perseusCode that's a comment for the CI to kickoff the build again. Apparently it failed so please fix it. |
The build break is because Microsoft.Graph.RBAC.dll 1.4 onwards are not compatible with Azure powershell. The SDK needs to be fixed to generate proper MAML library. |
Add 'type' parameter in cmdlet New-AzureDataFactoryEncryptValue for supporting file linked service encryption
retest this please |
servicePrincipal
servicePrincipal
Conflicts: src/ResourceManager/Resources/Commands.Resources.Test/Commands.Resources.Test.csproj src/ResourceManager/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADUserWithUPN.json src/ResourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADApplicationCommand.cs src/ResourceManager/Resources/Commands.Resources/Commands.Resources.csproj src/ResourceManager/Resources/Commands.Resources/Models.ActiveDirectory/ActiveDirectoryClient.cs src/ResourceManager/Resources/Commands.Resources/packages.config
servicePrincipal
servicePrincipal
servicePrincipal
Closing this as this PR is against master. |
This change contains following four cmdlets :-
a) New-AzureADApplication
b) Remove-AzureADApplication
c) New-AzureADServicePrincipal
d) Remove-AzureADServicePrincipal
These cmdlets are needed to maintain AD service princiapals. Tests for the same have also been added.