Skip to content

FW: Adding cmdlets for creating and deleting AD application & service principal #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 54 commits into from

Conversation

perseusCode
Copy link

This change contains following four cmdlets :-

a) New-AzureADApplication
b) Remove-AzureADApplication
c) New-AzureADServicePrincipal
d) Remove-AzureADServicePrincipal

These cmdlets are needed to maintain AD service princiapals. Tests for the same have also been added.

@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

azurecla commented Jan 8, 2015

Hi @perseusCode, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (mansikka). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@ogail
Copy link
Contributor

ogail commented Jan 9, 2015

add to whitelist

[Cmdlet(VerbsCommon.New, "AzureADApplication", DefaultParameterSetName = ParameterSet.ApplicationWithoutCredential), OutputType(typeof(PSADApplication))]
public class NewAzureADApplicationCommand : ActiveDirectoryBaseCmdlet
{
private string _KeyType = "AsymmetricX509Cert";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we don't use _ convention in PowerShell

@ogail
Copy link
Contributor

ogail commented Jan 12, 2015

retest this please

@perseusCode
Copy link
Author

Didn't get your comment, do you want me to run the unit tests again ?

@ogail
Copy link
Contributor

ogail commented Jan 12, 2015

@perseusCode that's a comment for the CI to kickoff the build again. Apparently it failed so please fix it.

@perseusCode
Copy link
Author

The build break is because Microsoft.Graph.RBAC.dll 1.4 onwards are not compatible with Azure powershell. The SDK needs to be fixed to generate proper MAML library.

jtlibingus and others added 3 commits January 13, 2015 20:02
Add 'type' parameter in cmdlet New-AzureDataFactoryEncryptValue for supporting file linked service encryption
@ogail
Copy link
Contributor

ogail commented Jan 13, 2015

retest this please

unknown added 14 commits January 13, 2015 13:33


Conflicts:
	src/ResourceManager/Resources/Commands.Resources.Test/Commands.Resources.Test.csproj
	src/ResourceManager/Resources/Commands.Resources.Test/SessionRecords/Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests/TestGetADUserWithUPN.json
	src/ResourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADApplicationCommand.cs
	src/ResourceManager/Resources/Commands.Resources/Commands.Resources.csproj
	src/ResourceManager/Resources/Commands.Resources/Models.ActiveDirectory/ActiveDirectoryClient.cs
	src/ResourceManager/Resources/Commands.Resources/packages.config


Conflicts:
	src/ResourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADApplicationCommand.cs
@perseusCode
Copy link
Author

Closing this as this PR is against master.

hyonholee referenced this pull request in hyonholee/azure-powershell Sep 4, 2015
hovsepm pushed a commit that referenced this pull request Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants