Skip to content

New cmdlets to create/enter PSSession in remote container app #7423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 2, 2018
Merged

New cmdlets to create/enter PSSession in remote container app #7423

merged 8 commits into from
Oct 2, 2018

Conversation

vinisoto
Copy link
Contributor

Description

Adding cmdlets for Entering/Creating a PowerShell remote session into a Windows Containers web app

Design Review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/145

These changes where excluded from a previous PR

Followed recommendations from @MiYanni and have made changes to check for PowerShell version and make sure that we don't expect WSMAN when not running on Windows.

Checklist

FYI @jvano , @panchagnula

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@cormacpayne
Copy link
Member

@azuresdkci add to whitelist

@vinisoto
Copy link
Contributor Author

vinisoto commented Oct 1, 2018

Skipped the test while investigation of PowerShell version in TRavis is ongoing. Opened this issue for tracking: #7440

@vinisoto vinisoto requested a review from MiYanni October 1, 2018 19:25
@vinisoto
Copy link
Contributor Author

vinisoto commented Oct 1, 2018

Hi @MiYanni - since all checks have passed. Would you mind reviewing this? I have opened an Issue to track the issue where xUnit configuration is using PowerShell 6.0 instead of 6.1.

Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add an entry for these changes to the Websites ChangeLog.md.

@vinisoto
Copy link
Contributor Author

vinisoto commented Oct 1, 2018

Thanks @MiYanni - updated the Changelog

@MiYanni MiYanni merged commit fdafbff into Azure:preview Oct 2, 2018
@vinisoto vinisoto deleted the windows_containers_pssession branch October 2, 2018 17:09
@vinisoto vinisoto restored the windows_containers_pssession branch October 2, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants