Fixes Docker image being out-of-date

[MiYanni]

Description

Fixes: #7286

I believe the Docker image name used to be microsoft/powershell. But, according to their docker page, it is now mcr.microsoft.com/powershell. Hopefully, this fixes our Docker image.

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate change log has been updated
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • the changes have gone through a cmdlet design review
  • the cmdlet markdown files were generated using the platyPS module

[MiYanni]

Tested. It fixes the issue with the container being wrong. However, there is another issue where the module seems to be missing our ADAL dll. That can be addressed in a separate issue. Here's what I ran:

docker pull azuresdk/azure-powershell-core:dockerimage-fix
docker run -it azuresdk/azure-powershell-core:dockerimage-fix pwsh


PS /usr/local/share/powershell/Modules/Az.Profile> ls
Az.Profile.psd1                                 Microsoft.Azure.Commands.Profile.types.ps1xml                  Microsoft.Azure.PowerShell.Common.dll           Microsoft.Azure.PowerShell.Storage.Management.dll      Microsoft.WindowsAzure.Storage.dll
Az.Profile.psm1                                 Microsoft.Azure.Common.dll                                     Microsoft.Azure.PowerShell.Compute.dll          Microsoft.Azure.PowerShell.Strategies.dll              NetCoreAssemblies
Hyak.Common.dll                                 Microsoft.Azure.PowerShell.Aks.dll                             Microsoft.Azure.PowerShell.Graph.Rbac.dll       Microsoft.Azure.PowerShell.Websites.dll                PreloadAssemblies
Microsoft.ApplicationInsights.dll               Microsoft.Azure.PowerShell.Authentication.Abstractions.dll     Microsoft.Azure.PowerShell.KeyVault.dll         Microsoft.Rest.ClientRuntime.Azure.Authentication.dll
Microsoft.Azure.Commands.Profile.deps.json      Microsoft.Azure.PowerShell.Authentication.dll                  Microsoft.Azure.PowerShell.Network.dll          Microsoft.Rest.ClientRuntime.Azure.dll
Microsoft.Azure.Commands.Profile.dll            Microsoft.Azure.PowerShell.Authentication.ResourceManager.dll  Microsoft.Azure.PowerShell.ResourceManager.dll  Microsoft.Rest.ClientRuntime.dll
Microsoft.Azure.Commands.Profile.format.ps1xml  Microsoft.Azure.PowerShell.Authorization.dll                   Microsoft.Azure.PowerShell.Storage.dll          Microsoft.WindowsAzure.Storage.DataMovement.dll
PS /usr/local/share/powershell/Modules/Az.Profile> Import-Module Az.Profile
Import-Module : Could not load file or assembly 'Microsoft.IdentityModel.Clients.ActiveDirectory, Version=3.14.0.8, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.
At line:1 char:1
+ Import-Module Az.Profile
+ ~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [Import-Module], FileNotFoundException
+ FullyQualifiedErrorId : System.IO.FileNotFoundException,Microsoft.PowerShell.Commands.ImportModuleCommand

Edit: Created #7460 for the issue.

[alexandair]

@MiYanni
azuresdk/azure-powershell-core:latest still wants to run pwsh-preview at start. so the container hangs if you don't specify pwsh with docker run.

[MiYanni]

@alexandair
The term pwsh-preview doesn't exist in this codebase. So, it isn't any kind of configuration from our side. Have you tried mcr.microsoft.com/powershell to see if the issue occurs there?

[alexandair]

I just know that I've just pulled the newer image with the "latest" tag and that image doesn't work by default. It wants to run "pwsh-preview" because this is what we did with the RC version of PowerShell Core. Now, that image uses the stable version, but somewhere in the Dockerfile used to build the image, CMD line still says pwsh-preview. I don't have another explanation why it behaves like that.

[MiYanni]

@alexandair
Does mcr.microsoft.com/powershell map to mcr.microsoft.com/powershell:latest? That's the only way that this shouldn't work correctly. Our entire Dockerfile is:

azure-powershell/Dockerfile

Lines 1 to 6 in 7336b43

	FROM mcr.microsoft.com/powershell
	ARG CONFIG=Release
	COPY src/Package/${CONFIG}/ResourceManager/AzureResourceManager /usr/local/share/powershell/Modules
	COPY tools/InstallationTests/NetcoreTests /azpstests

I could try updating it to mcr.microsoft.com/powershell:latest instead. But, my understanding is that the :latest shouldn't be required.

[MiYanni]

@alexandair
OH! I figured it out. You're trying to pull azuresdk/azure-powershell-core:latest. It isn't published yet. It won't be published until we do another release. Wait until then.
See: https://github.com/Azure/azure-powershell/milestones