Fix bug adding certificate to linux vmss, flatten exception and fix service fabric durability upgrade issue #7597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2018 16:06
… in case of failure
…KeyVaultClient.GetSecretAsync) and fixing add Cert to linux vmss ClientStore bug
|
Can one of the admins verify this patch? |
linmeng08
reviewed
Oct 17, 2018
...nager/ServiceFabric/Commands.ServiceFabric/Commands/ServiceFabricClusterCertificateCmdlet.cs
Show resolved
Hide resolved
linmeng08
previously approved these changes
Oct 17, 2018
|
@azuresdkci Retest this please |
juhacket
reviewed
Oct 19, 2018
...anager/ServiceFabric/Commands.ServiceFabric/Commands/UpdateAzureRmServiceFabricDurability.cs
Show resolved
Hide resolved
|
@azuresdkci Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing add certificate to Linux vmss. Set CertificateStore to null as this is an invalid parameter for Linux.
Fixing Add-AzureRmServiceFabricClusterCertificate: Throws AggregateException microsoft/service-fabric-issues#1054 flatten inner exception (KeyVaultClient.GetSecretAsync) so it is displayed correctly.
Fixing Update Service Fabric durability. Waiting for cluster configuration update to finish before starting vmss CreateOrUpdate operation, if the configuration upgrade fails there is no need to send the vmss operation, just show the exception.
Checklist
CONTRIBUTING.mdplatyPSmodule