[Compute] Update Compute client library to 23.2.0 #7687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@praries880 Obsolete makes a build failure. Shall I just add a warning message? |
cormacpayne
previously requested changes
Oct 29, 2018
There was a problem hiding this comment.
@hyonholee a few minor comments to take a look at, otherwise LGTM
...pute/Commands.Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs
Outdated
Show resolved
Hide resolved
src/ResourceManager/Compute/Commands.Compute/Manual/AddAzureRmVmssVMDataDiskCommand.cs
Outdated
Show resolved
Hide resolved
src/ResourceManager/Compute/Commands.Compute/Manual/AddAzureRmVmssVMDataDiskCommand.cs
Outdated
Show resolved
Hide resolved
src/ResourceManager/Compute/Commands.Compute/Manual/RemoveAzureRmVmssVMDataDiskCommand.cs
Outdated
Show resolved
Hide resolved
src/ResourceManager/Compute/Commands.Compute/Manual/RemoveAzureRmVmssVMDataDiskCommand.cs
Outdated
Show resolved
Hide resolved
…nto november # Conflicts: # src/ResourceManager/Compute/Commands.Compute.Test/Commands.Compute.Test.Netcore.csproj # src/ResourceManager/Compute/Commands.Compute.Test/Commands.Compute.Test.csproj # src/ResourceManager/Compute/Commands.Compute.Test/packages.config # src/ResourceManager/Compute/Commands.Compute/Commands.Compute.Netcore.csproj # src/ResourceManager/Compute/Commands.Compute/Commands.Compute.csproj # src/ResourceManager/Compute/Commands.Compute/packages.config # src/ResourceManager/Network/Commands.Network.Test/Commands.Network.Test.Netcore.csproj # src/ResourceManager/Network/Commands.Network.Test/Commands.Network.Test.csproj # src/ResourceManager/Network/Commands.Network.Test/packages.config # src/ResourceManager/RecoveryServices/Commands.RecoveryServices.Backup.Test/Commands.RecoveryServices.Backup.Test.Netcore.csproj # src/ResourceManager/RecoveryServices/Commands.RecoveryServices.Backup.Test/Commands.RecoveryServices.Backup.Test.csproj # src/ResourceManager/RecoveryServices/Commands.RecoveryServices.Backup.Test/packages.config
hyonholee
changed the title
|
@markcowl The SDK client referenced has been upgraded to Newtonsoft Json 10, so this should be ready to merge when code review is complete. |
markcowl
previously approved these changes
Oct 31, 2018
markcowl
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add-AzureRmVmssVMDataDisk and Remove-AzureRmVmssVMDataDisk
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/181
Description
Checklist
CONTRIBUTING.mdplatyPSmodule