Fix issue where EndDate parameter was not being honored for AD cmdlets #7710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markcowl
requested changes
Oct 31, 2018
...esourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADSpCredentialCommand.cs
Outdated
Show resolved
Hide resolved
...rceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADServicePrincipalCommand.cs
Outdated
Show resolved
Hide resolved
...ResourceManager/Resources/Commands.Resources/ActiveDirectory/NewAzureADApplicationCommand.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public override void ExecuteCmdlet() | ||
| { | ||
| if (!this.IsParameterBound(c => c.EndDate)) |
There was a problem hiding this comment.
A mocked test to prevent regressing this would be nice
markcowl
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #7700
There are a few cmdlets that don't respect the value of
-EndDateparameter, or don't get the accurate "one year after start date" default value, which is fixed in this PR.Checklist
CONTRIBUTING.mdplatyPSmodule