Skip to content

Release first version of Az.FrontDoor #7725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 7, 2018
Merged

Conversation

maddieclayton
Copy link
Contributor

Description

Checklist

@maddieclayton
Copy link
Contributor Author

@maddieclayton
Copy link
Contributor Author

@@ -15,7 +15,7 @@
ModuleVersion = '0.1.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend keeping this the same as all other Az module versions, 0.5.0. If you're looking to release it for the first time, maybe make it 0.5.1 since it missed the 0.5.0 module set?
We'll have to decide a version strategy for preview modules prior to Az 1.0 release. For now, let's keep them in-line with the rest of the Az modules (what we've been doing up until now).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be super sure that we only release stable modules as "1.0.0" in December - it would be bad if all of these preview modules that are supposed to stay preview get released as stable. Fixed for the time being though.

Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maddieclayton maddieclayton merged commit d27c625 into preview Nov 7, 2018
@maddieclayton maddieclayton deleted the maddieclayton-patch-1 branch November 7, 2018 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants