Skip to content

Update dev guide with ResourceNameCompleter #7737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2018
Merged

Conversation

maddieclayton
Copy link
Contributor

Description

Checklist

public string ServerName { get; set; }

[Parameter(Mandatory = false, HelpMessage = "The database name")]
[ResourceNameCompleter("Microsoft.Sql/servers/databases", "ResourceGroupName", "ServerName")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use nameof(ResourcegroupName) here instead of "ResourceGroupName". This will make these easier to review, and also ensure that any name change is always reflected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think we should make this part of the requirements in the design guidelines. Also, I think we should write up a blog post on this new feature.

@markcowl markcowl merged commit ea2b86f into preview Nov 9, 2018
@maddieclayton maddieclayton deleted the maddieclayton-patch-2 branch November 13, 2018 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants