[AzureStack] Update Fabric Admin Powershell cmdlet #7762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

maddieclayton merged 11 commits into Azure:preview from zyxyoshine:Oct2018FRP

Nov 16, 2018

Contributor

zyxyoshine commented Nov 7, 2018

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review (Microsoft internal partners only)
- the cmdlet markdown files were generated using the platyPS module

zyxyoshine added 3 commits

November 6, 2018 14:23


          Add and update cmdlet scripts

1682d70


          Add and update tests

3c3da94


          Update SessionRecords

zyxyoshine requested review from deathly809 and bganapa

November 7, 2018 05:36

Contributor Author

zyxyoshine commented Nov 7, 2018

@deathly809 @bganapa Please help review the changes.

Collaborator

adxsdkps commented Nov 7, 2018

Can one of the admins verify this patch?


          Merge branch 'preview' into Oct2018FRP

61f6b14

azuresdkci1x added the needs-review label

deathly809 added the Azure Stack label

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Module/Azs.Fabric.Admin.csproj Outdated Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Module/Azs.Fabric.Admin/Azs.Fabric.Admin.psd1 Outdated Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Module/Azs.Fabric.Admin/Azs.Fabric.Admin.psd1 Outdated Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Module/Azs.Fabric.Admin/Azs.Fabric.Admin.psd1 Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Module/Azs.Fabric.Admin/ChangeLog.md Outdated Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Module/Azs.Fabric.Admin/ChangeLog.md Outdated Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

...n/Module/Azs.Fabric.Admin/Generated.PowerShell.Commands/SwaggerPathCommands/Get-AzsDrive.ps1 Outdated Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

...n/Module/Azs.Fabric.Admin/Generated.PowerShell.Commands/SwaggerPathCommands/Get-AzsDrive.ps1 Outdated Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

...s.Fabric.Admin/Generated.PowerShell.Commands/SwaggerPathCommands/Get-AzsStorageSubSystem.ps1 Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

...s.Fabric.Admin/Generated.PowerShell.Commands/SwaggerPathCommands/Get-AzsStorageSubSystem.ps1 Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

.../Module/Azs.Fabric.Admin/Generated.PowerShell.Commands/SwaggerPathCommands/Get-AzsVolume.ps1 Outdated Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Module/packages.config Outdated Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Tests/Azs.Fabric.Admin.Tests.csproj Outdated Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Tests/src/Drive.tests.ps1 Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Tests/src/StorageSubSystem.tests.ps1 Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Tests/src/StorageSubSystem.tests.ps1 Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Tests/src/Volume.tests.ps1 Show resolved Hide resolved

deathly809 reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Tests/src/Volume.tests.ps1 Show resolved Hide resolved

Contributor

maddieclayton commented Nov 7, 2018

@azuresdkci Add to whitelist

maddieclayton assigned zyxyoshine

maddieclayton added needs-revision and removed needs-review labels

zyxyoshine added 5 commits

November 8, 2018 17:17


          fix comments

c544ff5


          Add negative tests

6b1188b


          Update SessionRecords

17cf1c1


          Merge branch 'Oct2018FRP' of https://github.com/zyxyoshine/azure-powe…

c5b0167

…rshell into Oct2018FRP


          Update change log

d273b81

Member

bganapa commented Nov 14, 2018

@zyxyoshine waiting on you to publish the SDK and update this PR

bganapa reviewed

View reviewed changes

src/StackAdmin/Azs.Fabric.Admin/Module/Azs.Fabric.Admin/Azs.Fabric.Admin.psd1 Show resolved Hide resolved


          Add alias support for Get- AzsInfrastructureVolume cmdlet

eeaac2d

bganapa approved these changes

View reviewed changes

bganapa added needs-review and removed needs-revision labels

bganapa unassigned zyxyoshine

Member

bganapa commented Nov 15, 2018

@maddieclayton websites related tests are failing here as well. I have restarted them

Contributor

maddieclayton commented Nov 15, 2018

@bganapa I'll merge preview into your branch - looks like it was an actually issue with preview, so just merged the fix.


          Merge branch 'preview' into Oct2018FRP

38daeb2

maddieclayton added Waiting for CI

and removed Azure Stack needs-review labels

maddieclayton approved these changes

View reviewed changes

maddieclayton merged commit 622034f into Azure:preview

This was referenced Nov 28, 2018

[AzureStack] Add help md files for new fabric admin cmdlet #7931

Closed

Updating release notes for the AzureStack release 1.6.0 #7924

Closed

cormacpayne added a commit to cormacpayne/azure-powershell that referenced this pull request


          Move changes from the following PRs into AzureRM branch:

d70895e

- Azure#7742
- Azure#7762
- Azure#7911

cormacpayne mentioned this pull request

Move AzureStack changes from preview into AzureRM #7939

Merged

8 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels