Skip to content

Fixes for SQL Replication Cmdlets and tests #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Aug 28, 2015
Merged

Conversation

dominiqa
Copy link
Contributor

No description provided.

Adding PowerShell for DBCopy and GeoDR operations in Resource Management

Conflicts:
	setup/azurecmdfiles.wxi
	src/ResourceManager/Sql/Commands.Sql.Test/Commands.Sql.Test.csproj
	src/ResourceManager/Sql/Commands.Sql.Test/packages.config
	src/ResourceManager/Sql/Commands.Sql/Commands.Sql.csproj
	src/ResourceManager/Sql/Commands.Sql/packages.config
-Branding
-partner RG check
-Error message change
Fixing Build Issue
… for potential errors

Updating Database Replication Test JSONs and streamlining test script
for potential errors
Fixing Build Issues from merge and cherry pick changes
Fixing GetLink Bug for CreateLink
Adding cmdlet help for GeoDR and DB Copy cmdlets
@azurecla
Copy link

Hi @dominiqa, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@@ -55,7 +55,8 @@ ScriptsToProcess = @()

# Type files (.ps1xml) to be loaded when importing this module
TypesToProcess = @(
'.\Compute\Microsoft.Azure.Commands.Compute.Types.ps1xml'
'.\Compute\Microsoft.Azure.Commands.Compute.Types.ps1xml',
'.\Sql\Microsoft.Azure.Commands.Sql.Types.ps1xml'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct spacing, pleaser

@markcowl
Copy link
Member

@dominiqa please respond to feedback

Fixes based on feedback comments:
-Fixed spacing in psd1 file
-Marked tests for Acceptance
Updated Wix file
Conflicts:
	src/ResourceManager/Sql/Commands.Sql.Test/Commands.Sql.Test.csproj
	src/ResourceManager/Sql/Commands.Sql/Commands.Sql.csproj
@dominiqa
Copy link
Contributor Author

All feedback addressed

@markcowl
Copy link
Member

@azuresdkci retest this please

@ogail
Copy link
Contributor

ogail commented Aug 27, 2015

@OJDUDE
Copy link

OJDUDE commented Aug 28, 2015

I signed the CLA. Is there anything else blocking the code merge?

markcowl added a commit that referenced this pull request Aug 28, 2015
Fixes for SQL Replication Cmdlets and tests
@markcowl markcowl merged commit dc1ffcc into Azure:dev Aug 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants