Add MongoDb migration support to DataMigration service #7831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@azuresdkci Add to whitelist |
haitsongmsft
force-pushed
the
preview
branch
from
f20be08 to
6215676
Compare
haitsongmsft
force-pushed
the
preview
branch
from
7bef84d to
231e264
Compare
haitsongmsft
force-pushed
the
preview
branch
from
231e264 to
43aa041
Compare
cormacpayne
suggested changes
Dec 5, 2018
There was a problem hiding this comment.
@haitsongmsft a few minor comments to take a look at
@cormacpayne the conflict is resolved.
src/ResourceManager/DataMigration/Commands.DataMigration/AzureRM.DataMigration.psd1
Outdated
Show resolved
Hide resolved
src/ResourceManager/DataMigration/Commands.DataMigration/Cmdlets/NewDataMigrationTask.cs
Outdated
Show resolved
Hide resolved
...ourceManager/DataMigration/Commands.DataMigration/Models/MongoDb/MongoDbCollectionSetting.cs
Outdated
Show resolved
Hide resolved
...rceManager/DataMigration/Commands.DataMigration/Cmdlets/NewMongoDbCollectionSettingCmdlet.cs
Outdated
Show resolved
Hide resolved
...rceManager/DataMigration/Commands.DataMigration/Cmdlets/NewMongoDbCollectionSettingCmdlet.cs
Show resolved
Hide resolved
...ourceManager/DataMigration/Commands.DataMigration/Cmdlets/NewMongoDbDatabaseSettingCmdlet.cs
Outdated
Show resolved
Hide resolved
...ourceManager/DataMigration/Commands.DataMigration/Cmdlets/NewMongoDbDatabaseSettingCmdlet.cs
Show resolved
Hide resolved
...ger/DataMigration/Commands.DataMigration/help/New-AzDataMigrationMongoDbCollectionSetting.md
Outdated
Show resolved
Hide resolved
|
@haitsongmsft ping on the comments above |
haitsongmsft
force-pushed
the
preview
branch
from
5a65638 to
be5f720
Compare
cormacpayne
added
Cmdlet Review Complete
needs-review
and removed
Cmdlet Review Required ⚠️
needs-revision
labels
|
@haitsongmsft would you mind resolving the merge conflicts? |
haitsongmsft
force-pushed
the
preview
branch
from
f527eab to
d474f86
Compare
cormacpayne
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/207
Checklist
CONTRIBUTING.mdplatyPSmodule