-
Notifications
You must be signed in to change notification settings - Fork 4k
Resolve issue https://github.com/Azure/azure-powershell/issues/6161 #7839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You need to update the
ChangeLog.md
for DataFactoryV2. I'll use that ChangeLog as the primary changelog when I make DataFactories and DataFactoryV2 into the same module.
src/ResourceManager/DataFactories/Commands.DataFactories/Commands.DataFactories.Netcore.csproj
Outdated
Show resolved
Hide resolved
src/ResourceManager/DataFactories/Commands.DataFactories/Commands.DataFactories.Netcore.csproj
Outdated
Show resolved
Hide resolved
@azuresdkci Add to whitelist |
@maddieclayton What does "Add to whitelist" do? |
@MiYanni by default, when a user first opens a PR in this repo (and other Azure repos), Jenkins CI won't run against that user's PR until they've been added to the whitelist, which is what the above command does. |
<PackageReference Include="Microsoft.DataTransfer.Gateway.Encryption" Version="3.4.6604.1" /> | ||
<PackageReference Include="Microsoft.DataTransfer.Gateway.Encryption" Version="3.11.6886.9" /> | ||
<PackageReference Include="System.IO.FileSystem.AccessControl" Version="4.5.0" /> | ||
<PackageReference Include="WindowsAzure.Storage" Version="9.3.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add these dlls in the RequiredAssemblies
section of Az.DataFactories.psd1
. The management dll and the encryption dll are already listed. You'll need the AccessControl and Storage dlls there too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
…crosoft.WindowsAzure.Storage.dll into Az.DataFactories.psd1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Checklist
CONTRIBUTING.md
platyPS
module