Skip to content

Resolve issue https://github.com/Azure/azure-powershell/issues/6161 #7839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 20, 2018
Merged

Resolve issue https://github.com/Azure/azure-powershell/issues/6161 #7839

merged 5 commits into from
Nov 20, 2018

Conversation

zhangyd2015
Copy link
Contributor

Description

Checklist

@zhangyd2015 zhangyd2015 requested a review from MiYanni November 15, 2018 13:57
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You need to update the ChangeLog.md for DataFactoryV2. I'll use that ChangeLog as the primary changelog when I make DataFactories and DataFactoryV2 into the same module.

@maddieclayton
Copy link
Contributor

@azuresdkci Add to whitelist

@MiYanni
Copy link
Contributor

MiYanni commented Nov 15, 2018

@maddieclayton What does "Add to whitelist" do?

@cormacpayne
Copy link
Member

@MiYanni by default, when a user first opens a PR in this repo (and other Azure repos), Jenkins CI won't run against that user's PR until they've been added to the whitelist, which is what the above command does.

<PackageReference Include="Microsoft.DataTransfer.Gateway.Encryption" Version="3.4.6604.1" />
<PackageReference Include="Microsoft.DataTransfer.Gateway.Encryption" Version="3.11.6886.9" />
<PackageReference Include="System.IO.FileSystem.AccessControl" Version="4.5.0" />
<PackageReference Include="WindowsAzure.Storage" Version="9.3.0" />
Copy link
Contributor

@MiYanni MiYanni Nov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add these dlls in the RequiredAssemblies section of Az.DataFactories.psd1. The management dll and the encryption dll are already listed. You'll need the AccessControl and Storage dlls there too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

…crosoft.WindowsAzure.Storage.dll into Az.DataFactories.psd1
Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants