Skip to content

[RecoveryServices.Backup] Making storage account and RG name optional for AFS restore #7886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2018
Merged

[RecoveryServices.Backup] Making storage account and RG name optional for AFS restore #7886

merged 1 commit into from
Nov 27, 2018

Conversation

siddharth7
Copy link
Contributor

Description

Checklist

@siddharth7 siddharth7 changed the title making storage account and rg name optional for afs restore [RecoveryServices.Backup] Making storage account and RG name optional for AFS restore Nov 22, 2018
@siddharth7 siddharth7 force-pushed the users/sisi/afs-restore-update branch 3 times, most recently from 3e674f5 to 9da4a66 Compare November 22, 2018 11:59
@siddharth7 siddharth7 force-pushed the users/sisi/afs-restore-update branch 3 times, most recently from e7a4b4b to a8c7df2 Compare November 22, 2018 12:08
dragonfly91
dragonfly91 previously approved these changes Nov 22, 2018
View reviewed changes
Copy link

@dragonfly91 dragonfly91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of one comment. Otherwise LGTM.

@cormacpayne
Copy link
Member

@siddharth7 would you mind resolving the merge conflicts?

@siddharth7 siddharth7 force-pushed the users/sisi/afs-restore-update branch from a8c7df2 to eef7401 Compare November 26, 2018 18:54
@siddharth7
Copy link
Contributor Author

siddharth7 commented Nov 26, 2018 •
edited
Loading

@cormacpayne Resolved. Got them due to #7888 .

@cormacpayne cormacpayne merged commit 7e02bcd into Azure:preview Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cormacpayne cormacpayne cormacpayne approved these changes

@dragonfly91 dragonfly91 dragonfly91 left review comments

Assignees

@siddharth7 siddharth7

Labels
needs-revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siddharth7 @cormacpayne @dragonfly91 @azuresdkci