Skip to content

2: Removed StackAdmin folder #7914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2018
Merged

Conversation

MiYanni
Copy link
Contributor

@MiYanni MiYanni commented Nov 27, 2018

Removes StackAdmin folder.

@MiYanni MiYanni changed the title Removed StackAdmin folder 2: Removed StackAdmin folder Nov 27, 2018
@MiYanni MiYanni mentioned this pull request Nov 27, 2018
8 tasks
# Conflicts:
#	src/StackAdmin/Azs.InfrastructureInsights.Admin/Help/Azs.InfrastructureInsights.Admin.md
#	src/StackAdmin/Azs.InfrastructureInsights.Admin/Module/Azs.InfrastructureInsights.Admin/Azs.Infrastructureinsights.Admin.psd1
#	src/StackAdmin/Compute/Commands.Compute/Extension/NetcoreExtension.cs
#	src/StackAdmin/Resources/Commands.ResourceManager/Cmdlets/Components/ApiVersionHelper.cs
#	src/StackAdmin/Resources/Commands.ResourceManager/Cmdlets/Json/CamelCasePropertyNamesWithOverridesContractResolver.cs
#	src/StackAdmin/Resources/Commands.Resources/Models.ResourceGroups/ResourceClient.cs
#	src/StackAdmin/Resources/Commands.Resources/Models.ResourceGroups/ResourcesBaseCmdlet.cs
#	src/StackAdmin/Resources/Commands.Resources/Models.ResourceGroups/ResourcesExtensions.cs
@deathly809
Copy link
Member

Could you give some info on this? Will this eventually make it to master/preview branch?

@MiYanni
Copy link
Contributor Author

MiYanni commented Nov 28, 2018

@deathly809 For Stack, we are opting to have it be separate since most of the code/cmdlets aren't following the same processes as the rest of the service teams. Our initial thought is there would be a permanent stack branch. Your code should need nothing from this repo directly, so that's why we are handling it as a separate endeavor. You use our common repo packages for your process, so nothing here in our module repo should apply.

Currently, you have separate copies of our modules here too, since they are locked to certain APIs. We will be doing an Azure Profile integration for the modules in 2019. So, eventually, you'll just consume a Profile of those cmdlets, and not need your own separate copies of the source code either.

@bganapa
Copy link
Member

bganapa commented Nov 28, 2018

@MiYanni we have a release scheduled for Dec 1st week. Can this wait till then?

an open PR for this release #7924

@MiYanni
Copy link
Contributor Author

MiYanni commented Nov 28, 2018

@bganapa This work is scheduled post Az 1.0 release. So, past December 18th. After then, we are migrating from having the primary branch of this repo be preview to instead be dev. The branch that this PR is targeting, az-cleanup, will be merged into dev in late December.

@MiYanni MiYanni merged commit c92603d into Azure:az-cleanup Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants