Skip to content

Fixed ServerActiveDirectoryAdministratorTest #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2015
Merged

Fixed ServerActiveDirectoryAdministratorTest #797

merged 2 commits into from
Aug 25, 2015

Conversation

j82w
Copy link

@j82w j82w commented Aug 25, 2015

Removed a check for the graph endpoint when setting the Azure SQL Server Active Directory administrator that caused the test to fail.

Fixed ServerActiveDirectoryAdministratorTest. Removed a check for the…
53ff083 
… graph endpoint when setting the Azure SQL Server Active Directory administrator that caused the test to fail.
@azurecla
Copy link

Hi @j82w, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (jawilley). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@akromm-zz
Copy link
Contributor

Looks good to me.

@j82w j82w closed this Aug 25, 2015
@j82w j82w reopened this Aug 25, 2015
@azurecla
Copy link

Hi @j82w, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (jawilley). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

markcowl
markcowl reviewed Aug 25, 2015
View reviewed changes
...erActiveDirectoryAdministrator/Services/AzureSqlServerActiveDirectoryAdministratorAdapter.cs
@@ -65,10 +65,6 @@ public MicrosoftAzureCommandsResourcesModelsActiveDirectory.ActiveDirectoryClien
{
if (_activeDirectoryClient == null)
{
if (!Profile.Context.Environment.IsEndpointSet(AzureEnvironment.Endpoint.Graph))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a safe change? Do you need the graph endpoint in one of your clients?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the check back in with the latest commit, and set the graph endpoint in the test framework.

markcowl added a commit that referenced this pull request Aug 25, 2015
@markcowl
Merge pull request #797 from j82w/dev
bf08051 
Fixed ServerActiveDirectoryAdministratorTest
@markcowl markcowl merged commit bf08051 into Azure:dev Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j82w @azurecla @akromm-zz @markcowl