Skip to content

AzureRT updates #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Aug 31, 2015
Merged

AzureRT updates #800

merged 18 commits into from
Aug 31, 2015

Conversation

hyonholee
Copy link
Contributor

  1. Change the warning message to a non-terminating error message for ResourceNotFound in VM cmdlets (ASM).
  2. Add Id parameter for VM cmdlets (ARM) to support piping scenario without ResourceGroupName parameter.
  3. Fix Set-AzureVMAccess extension
  4. Update Publish-AzurePlatformExtension and Set-AzurePlatformExtension cmdlets
  5. Adding Add-AzureVhd cmdlet for ARM
    AzurePS 0.8.13 :: Azure Virtual Machine commands silently fail #115
    *AzureVM cmdlets in ResourceManager should have an "Id" parameter #369

@azurecla
Copy link

Hi @hyonholee, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (hylee). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

huangpf
huangpf reviewed Aug 25, 2015
View reviewed changes
...urceManager/Compute/Commands.Compute/VirtualMachine/Action/VirtualMachineActionBaseCmdlet.cs
[Parameter(
Mandatory = true,
Position = 0,
ParameterSetName = IdParameterSet,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any child parameter derive from this base cmdlet class has another parameter set, will it have access to this parameter defined in IdParameterSet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an interesting question. Currently all child cmdlets of this base method do not have an additional parameter set. I think a child cmdlet can have more parameter sets in addition to these parameter sets.

@huangpf
Copy link
Contributor

huangpf commented Aug 25, 2015

LGTM

@markcowl
Copy link
Member

@hyonholee Please pull the latest and resubmit

@markcowl
Copy link
Member

@hyonholee Also, can you please submit changes to changelog.md for this and the previous PR?

@markcowl
Copy link
Member

@azuresdkci retest this please

@markcowl
Copy link
Member

@hyonholee Test failures

huangpf
huangpf reviewed Aug 28, 2015
View reviewed changes
src/ResourceManager/Compute/Commands.Compute/StorageServices/AddAzureVhdCommand.cs
[ValidateNotNullOrEmpty]
[Alias("dst")]
public Uri Destination
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make it one line { get; set; }

@markcowl
Copy link
Member

@azuresdkci retest this please

@markcowl
Copy link
Member

on demand run is here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/164/

markcowl added a commit that referenced this pull request Aug 31, 2015
@markcowl
Merge pull request #800 from hyonholee/dev
f12e985 
AzureRT updates
@markcowl markcowl merged commit f12e985 into Azure:dev Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyonholee @azurecla @huangpf @markcowl