10: Renames Insights and Profile modules #8019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd output folder names.
…er, tests will not run currently without a Common change to RMProfileModule. Will be in follow up commit.
…s. Removed unused net452/service management targets files. Updated Common packages references.
markcowl
reviewed
Dec 6, 2018
| @@ -19,7 +19,7 @@ | |||
| <PrivateAssets Condition="'$(HideReferenceDependencies)' == 'true'">All</PrivateAssets> | |||
| </PackageReference> | |||
| <PackageReference Include="xunit" Version="2.4.0" /> | |||
| <PackageReference Include="Microsoft.Azure.PowerShell.ScenarioTest.ResourceManager" Version="1.1.8-preview" > | |||
| <PackageReference Include="Microsoft.Azure.PowerShell.ScenarioTest.ResourceManager" Version="1.0.231-preview" > | |||
There was a problem hiding this comment.
I don't think we can publish with this - we'll need the new actual version before moving into master
markcowl
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the module renames from #6958. Also, removed the net452 targets files since they are unused.
Summary:
Note: This requires Common changes. Currently, this uses the LocalFeed for these changes. I will be making another PR with Common assembly renames, and that PR will have a published version instead of using LocalFeed.