Skip to content

11: Update module & Common DLL names #8034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 7, 2018

Conversation

MiYanni
Copy link
Contributor

@MiYanni MiYanni commented Dec 6, 2018

This changes the names of the DLLs to coincide with #7374
The Common changes are here: Azure/azure-powershell-common#101

…iles that don't exist. Removed WindowsAzurePowerShell.Test project as it is unused. Removed Add-AzureHelpKeywords.ps1 as it is unused. Removed 2 Azure.*.psd1 files as they are unused. Renamed all module and module test projects to use Microsoft.Azure.PowerShell.Cmdlets as their assembly name header. Appropriately named Insights and Profile to Monitor and Accounts to match the name changes from previous PRs.
…leaning folders that don't exist. Fixed Resources loading wrong DLL name.
'.\Microsoft.Azure.PowerShell.Graph.Rbac.dll',
'.\Microsoft.Azure.PowerShell.Network.dll',
'.\Microsoft.Azure.PowerShell.ResourceManager.dll',
'.\Microsoft.Azure.PowerShell.Clients.Authorization.dll',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question: are we going to change the profile directory as part of this, or is that too big a change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No directory changes/moving files happened in az-cleanup. It would have caused a lot of unnecessary merge conflicts and had no benefits for Az 1.0. I'll be cleaning/updating the repo in the next few weeks to reduce the directory structure and rename things. As a note, a lot of our processes are tied to names and directory structure. So, this would have been fairly massive to change for the entire repo right now. After Az 1.0, it will be easier to do.

@@ -66,7 +66,7 @@
<PackageReference Include="PowerShellStandard.Library" Version="5.1.0-preview-06" PrivateAssets="All" />
</ItemGroup>
<PropertyGroup>
<StorageToolsPath>$(NugetPackageRoot)microsoft.azure.powershell.storage\1.0.231-preview\tools\</StorageToolsPath>
<StorageToolsPath>$(NugetPackageRoot)microsoft.azure.powershell.storage\1.0.233-preview\tools\</StorageToolsPath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per previous note, this is OK for now, but will need to update to the latest published before we release

@markcowl markcowl merged commit e40a0fd into Azure:az-cleanup Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants