Skip to content

Insights breaking changes #8075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2018
Merged

Insights breaking changes #8075

merged 3 commits into from
Dec 10, 2018

Conversation

maddieclayton
Copy link
Contributor

Description

Checklist

@maddieclayton maddieclayton added the Breaking Change Release This PR contains breaking change label Dec 10, 2018
@cormacpayne
Copy link
Member

@gucalder Hey Guillermo, would you mind taking a look at this PR we are looking to get into the breaking change release?

gucalder
gucalder approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@gucalder gucalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for doing this!

@cormacpayne cormacpayne merged commit 114552b into Azure:master Dec 10, 2018
@maddieclayton maddieclayton deleted the insights branch December 17, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cormacpayne cormacpayne cormacpayne approved these changes

@gucalder gucalder gucalder approved these changes

Assignees

@cormacpayne cormacpayne

Labels
Breaking Change Release This PR contains breaking change needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maddieclayton @cormacpayne @gucalder @azuresdkci