[RecoveryServices.Backup] Removing name param from container #8088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth7
force-pushed
the
rs_breaking
branch
2 times, most recently
from
877229c to
37f81de
Compare
siddharth7
force-pushed
the
rs_breaking
branch
2 times, most recently
from
39e4ceb to
bcc4c4e
Compare
siddharth7
force-pushed
the
rs_breaking
branch
from
bcc4c4e to
6895f65
Compare
siddharth7
changed the title
markcowl
requested changes
Dec 12, 2018
| @@ -30,7 +30,7 @@ public ContainerTests(Xunit.Abstractions.ITestOutputHelper output) | |||
| XunitTracingInterceptor.AddToContext(_logger); | |||
| } | |||
|
|
|||
| [Fact] | |||
| [Fact(Skip = "This workload is not supported anymore")] | |||
There was a problem hiding this comment.
Remove this test if it is not supported - same for all the other skips
| @@ -30,7 +30,7 @@ public ItemTests(Xunit.Abstractions.ITestOutputHelper output) | |||
| XunitTracingInterceptor.AddToContext(_logger); | |||
| } | |||
|
|
|||
| [Fact] | |||
| [Fact(Skip = "This workload is not supported anymore")] | |||
There was a problem hiding this comment.
See comment above - remove skipped tests if this is no longer supported
...mands.RecoveryServices.Backup/Cmdlets/Container/GetAzureRmRecoveryServicesBackupContainer.cs
Show resolved
Hide resolved
siddharth7
force-pushed
the
rs_breaking
branch
2 times, most recently
from
33f92dd to
6895f65
Compare
markcowl
requested changes
Dec 13, 2018
| @@ -194,23 +194,12 @@ public AzureWorkloadProviderHelper(ServiceClientAdapter serviceClientAdapter) | |||
| { | |||
| string vaultName = (string)providerData[CmdletModel.VaultParams.VaultName]; | |||
| string vaultResourceGroupName = (string)providerData[CmdletModel.VaultParams.ResourceGroupName]; | |||
| string name = (string)providerData[CmdletModel.ContainerParams.Name]; | |||
There was a problem hiding this comment.
See the file change above - remove this file 'set'
| @@ -39,7 +39,7 @@ public void TestAzureSqlGetContainers() | |||
| _logger, PsBackupProviderTypes.AzureSql, "Test-AzureSqlGetContainers"); | |||
| } | |||
|
|
|||
| [Fact] | |||
| [Fact(Skip = "This workload is not supported anymore")] | |||
There was a problem hiding this comment.
You need to remove these unsupported scenario tests, not skip them
There was a problem hiding this comment.
Can I take this is next release? We have a whole cleanup to do related to this workload
|
@siddharth7 Note please make these changes in the next few hours, or this PR will not be merged an no breaking changes will be possible. |
markcowl
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdplatyPSmodule