[Test Controller] New test controller applied to Compute #8273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

vladimir-shcherbakov merged 3 commits into Azure:master from vladimir-shcherbakov:tc-core-compute

Jan 30, 2019

Contributor

vladimir-shcherbakov commented Jan 10, 2019 •

edited

Loading

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review (Microsoft internal partners only)
- the cmdlet markdown files were generated using the platyPS module


          New test controller applied to Compute

943c53a

azuresdkci added the needs-review label

vladimir-shcherbakov changed the title ~~New test controller applied to Compute~~ [Test Controller] New test controller applied to Compute

MiYanni suggested changes

View reviewed changes

src/Compute/Compute.Test/ScenarioTests/ComputeTestRunner.cs Outdated

+                                  helper.RMProfileModule,
+              #if !NETSTANDARD
+                                  helper.RMStorageDataPlaneModule,
+              #endif

Contributor

MiYanni Jan 22, 2019

Please delete this #if statement as it is not used.

src/Compute/Compute.Test/ScenarioTests/LogAnalyticTests.cs Outdated

                       }
                       [Fact]
                       [Trait(Category.AcceptanceType, Category.CheckIn)]
                       public void TestExportLogAnalyticThrottledRequestsNegative()
                       {
-                          ComputeTestController.NewInstance.RunPsTest(_logger, "Test-ExportLogAnalyticThrottledRequestsNegative");
+                          TestRunner.RunTestScript("Test-ExportLogAnalyticThrottledRequestsNegative");

Contributor

MiYanni Jan 22, 2019

Excess carriage return.

src/Compute/Compute.Test/ScenarioTests/StrategiesVirtualMachineTests.cs Outdated

                       }
                       [Fact]
                       [Trait(Category.AcceptanceType, Category.CheckIn)]
                       public void TestSimpleNewVm()
                       {
-                          ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVm");
+                          TestRunner.RunTestScript("Test-SimpleNewVm");

Contributor

MiYanni Jan 22, 2019

Excess carriage return.

src/Compute/Compute.Test/ScenarioTests/StrategiesVmssTests.cs Outdated

                       [Trait(Category.AcceptanceType, Category.CheckIn)]
                       public void TestSimpleNewVmss()
                       {
-                          ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmss");
+              //            ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmss");

Contributor

MiYanni Jan 22, 2019

Remove commented code.

src/Compute/Compute.Test/ScenarioTests/StrategiesVmssTests.cs Outdated

                       }
                       [Fact]
                       [Trait(Category.AcceptanceType, Category.CheckIn)]
                       public void TestSimpleNewVmssFromSIGImage()
                       {
-                          ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssFromSIGImage");
+              //            ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssFromSIGImage");

Contributor

MiYanni Jan 22, 2019

Remove commented code.

src/Compute/Compute.Test/ScenarioTests/StrategiesVmssTests.cs Outdated

                       }
                       [Fact]
                       [Trait(Category.AcceptanceType, Category.CheckIn)]
                       public void TestSimpleNewVmssWithUltraSSD()
                       {
-                          ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssWithUltraSSD");
+              //            ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssWithUltraSSD");

Contributor

MiYanni Jan 22, 2019

Remove commented code.

src/Compute/Compute.Test/ScenarioTests/StrategiesVmssTests.cs Outdated

                       }
                       [Fact]
                       [Trait(Category.AcceptanceType, Category.CheckIn)]
                       public void TestSimpleNewVmssLbErrorScenario()
                       {
-                          ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssLbErrorScenario");
+              //            ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssLbErrorScenario");

Contributor

MiYanni Jan 22, 2019

Remove commented code.

src/Compute/Compute.Test/ScenarioTests/StrategiesVmssTests.cs Outdated

                       }
                       [Fact]
                       [Trait(Category.AcceptanceType, Category.CheckIn)]
                       public void TestSimpleNewVmssWithSystemAssignedIdentity()
                       {
-                          ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssWithSystemAssignedIdentity");
+              //            ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssWithSystemAssignedIdentity");

Contributor

MiYanni Jan 22, 2019

Remove commented code.

src/Compute/Compute.Test/ScenarioTests/StrategiesVmssTests.cs Outdated

                       }
                       [Fact]
                       [Trait(Category.AcceptanceType, Category.CheckIn)]
                       public void TestSimpleNewVmssImageName()
                       {
-                          ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssImageName");
+              //            ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssImageName");

Contributor

MiYanni Jan 22, 2019

Remove commented code.

src/Compute/Compute.Test/ScenarioTests/StrategiesVmssTests.cs Outdated

                            * Get-AzureRmUserAssignedIdentity -ResourceGroupName UAITG123456 -Name UAITG123456Identity
                            * Nore down the Id and use it in the PS code
                            * */
-                          ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssWithsystemAssignedUserAssignedIdentity");
+              //            ComputeTestController.NewInstance.RunPsTest(_logger, "Test-SimpleNewVmssWithsystemAssignedUserAssignedIdentity");

Contributor

MiYanni Jan 22, 2019

Remove commented code.

MiYanni added needs-revision and removed needs-review labels

MiYanni assigned vladimir-shcherbakov

MiYanni added the Merge Conflicts label

vladimir-shcherbakov added 2 commits

January 23, 2019 19:25


          Merge remote-tracking branch 'us/master' into tc-core-compute

66caf28

# Conflicts:
#	src/Compute/Compute.Test/Common/ComputeTestController.cs


          PR commetns fixed

bad6836

vladimir-shcherbakov added needs-review and removed Merge Conflicts needs-revision labels

vladimir-shcherbakov assigned hyonholee and unassigned vladimir-shcherbakov

Contributor Author

vladimir-shcherbakov commented Jan 24, 2019

@hyonholee We are applying a new test controller - could you take a look?

hyonholee approved these changes

View reviewed changes

vladimir-shcherbakov assigned MiYanni and unassigned hyonholee

Contributor Author

vladimir-shcherbakov commented Jan 29, 2019

@MiYanni Are you ready to sign off?

MiYanni approved these changes

View reviewed changes

Contributor Author

vladimir-shcherbakov commented Jan 29, 2019

signing: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/psnetsign-esrp/119/

vladimir-shcherbakov added Waiting for CI

and removed needs-review labels

vladimir-shcherbakov merged commit c325faa into Azure:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels