Authorization: Changes to the Get-AzureRoleAssignment commandlet to also display classic admins and perform group expansion for users #846
Conversation
… user groups as well as return classic admins
|
Hi @namratab, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
@namratab tests failed. Also, the dev branch is closed until mid next week. You can still make the 0.9.8 release, if you target this at the release-0.9.8 branch - we have pushed out code complete until Friday. |
|
Thanks, I will send out a new PR against the release branch |
…e. Update to latest version only for Resources and Resources.test proejcts
…e to build error. Fix Network tests and record
…hat uses a custom api version for microsoft.authotization
…authorization api version
|
I've used a custom recordmatcher to exclude api versions for matching the Microsoft.authorization permissions api calls across different RPs. The API contract is exactly the same and only change is to go from a "preview" version to non-preview. |
| @@ -96,6 +97,10 @@ public void RunPsTest(params string[] scripts) | |||
| string callingClassType, | |||
| string mockName) | |||
| { | |||
| Dictionary<string, string> d = new Dictionary<string, string>(); | |||
There was a problem hiding this comment.
could u move this code to RMTestBase instead of duplicating it everywhere in the code?
There was a problem hiding this comment.
This is used only for a few of the test projects which depend on authorization RP. Not needed for all tests. Is there benefit in moving it there? Keeping it here also makes it explicit that en exclusion is added for particular test projects only.
…gnmentmerge Conflicts: src/ResourceManager/Resources/Commands.Resources/Models.Authorization/AuthorizationClient.cs src/ResourceManager/Resources/Commands.Resources/Models.Authorization/FilterRoleAssignmentsOptions.cs src/ResourceManager/Resources/Commands.Resources/RoleAssignments/GetAzureRoleAssignmentCommand.cs src/ResourceManager/Resources/Commands.Resources/RoleAssignments/RemoveAzureRoleAssignmentCommand.cs
Authorization: Changes to the Get-AzureRoleAssignment commandlet to also display classic admins and perform group expansion for users
Authorization: Changes to the Get-AzureRoleAssignment commandlet to also display classic admins and perform group expansion for users