Skip to content

Add wildcard support to Compute #8492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 2, 2019
Merged

Add wildcard support to Compute #8492

merged 14 commits into from
Mar 2, 2019

Conversation

maddieclayton
Copy link
Contributor

@maddieclayton maddieclayton commented Feb 6, 2019 •
edited
Loading

Description

#6549

Checklist

@maddieclayton maddieclayton self-assigned this Feb 6, 2019
@maddieclayton
Copy link
Contributor Author

sign job here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/psnetsign-esrp/139/

@maddieclayton
Copy link
Contributor Author

Updated sign job with PowerShell wildcard support: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/psnetsign-esrp/144/

cormacpayne
cormacpayne suggested changes Feb 28, 2019
View reviewed changes
src/Compute/Compute/help/Get-AzVM.md
Get-AzVM [-ResourceGroupName] <String> [-Status] [-DefaultProfile <IAzureContextContainer>]
[<CommonParameters>]
Get-AzVM [[-ResourceGroupName] <String>] [[-Name] <String>] [-Status]
[-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maddieclayton it would be nice if we could add an example in this file (and other affected cmdlets) that uses the wildcard, as well as updating the description for the affected parameters letting users know that wildcards are accepted :shipit:

@cormacpayne cormacpayne removed their assignment Mar 1, 2019
@maddieclayton maddieclayton merged commit 29136b8 into Azure:master Mar 2, 2019
@maddieclayton maddieclayton deleted the wildcard1 branch March 2, 2019 07:04
@maddieclayton maddieclayton mentioned this pull request Mar 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cormacpayne cormacpayne cormacpayne approved these changes

Assignees
No one assigned
Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maddieclayton @cormacpayne @azuresdkci @hyonholee